Skip to content

chore: Simplify and optimize interpolate implementation #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2025
Merged

chore: Simplify and optimize interpolate implementation #8397

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53edcc
Use binsearch in the interpolate implementation
MatiPl01 Oct 15, 2025
9565bc9
Restore Podfile.lock
MatiPl01 Oct 15, 2025
54f6ac7
Apply review suggestion
MatiPl01 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions packages/react-native-reanimated/src/interpolation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,29 +191,35 @@ export function interpolate(

const extrapolationConfig = validateType(type);
const length = inputRange.length;
const narrowedInput: InterpolationNarrowedInput = {
leftEdgeInput: inputRange[0],
rightEdgeInput: inputRange[1],
leftEdgeOutput: outputRange[0],
rightEdgeOutput: outputRange[1],
};
if (length > 2) {
if (x > inputRange[length - 1]) {
narrowedInput.leftEdgeInput = inputRange[length - 2];
narrowedInput.rightEdgeInput = inputRange[length - 1];
narrowedInput.leftEdgeOutput = outputRange[length - 2];
narrowedInput.rightEdgeOutput = outputRange[length - 1];
} else {
for (let i = 1; i < length; ++i) {
if (x <= inputRange[i]) {
narrowedInput.leftEdgeInput = inputRange[i - 1];
narrowedInput.rightEdgeInput = inputRange[i];
narrowedInput.leftEdgeOutput = outputRange[i - 1];
narrowedInput.rightEdgeOutput = outputRange[i];
break;
}
let narrowedInput: InterpolationNarrowedInput;

if (x > inputRange[length - 1]) {
narrowedInput = {
leftEdgeInput: inputRange[length - 2],
rightEdgeInput: inputRange[length - 1],
leftEdgeOutput: outputRange[length - 2],
rightEdgeOutput: outputRange[length - 1],
};
} else {
let left = 0;
let right = length - 1;

while (left < right) {
const mid = Math.floor((left + right) / 2);
if (x <= inputRange[mid]) {
right = mid;
} else {
left = mid + 1;
}
}

const segmentIndex = Math.max(1, left);
narrowedInput = {
leftEdgeInput: inputRange[segmentIndex - 1],
rightEdgeInput: inputRange[segmentIndex],
leftEdgeOutput: outputRange[segmentIndex - 1],
rightEdgeOutput: outputRange[segmentIndex],
};
}

return internalInterpolate(x, narrowedInput, extrapolationConfig);
Expand Down
Loading