Skip to content

Commit c20adf2

Browse files
committed
cli - enable etcd-on-ramdisk option
Change-Id: Iacab72ddd78c5a57ae75f6043a3b7a5d49d386a1
1 parent 7d8150b commit c20adf2

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

cli/cmd/dev/dev.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ var devRunTestsAllowedArgs = []string{"olm", "standalone", "upgrade"}
4444

4545
var microshiftUser = "cloud-user"
4646
var defaultDiskSpace = "20G"
47+
var defaultHost = "microshift.dev"
4748

4849
var errMissingArg = errors.New("missing argument")
4950

@@ -73,8 +74,8 @@ func createMicroshift(kmd *cobra.Command, cliCtx cliutils.SoftwareFactoryConfigC
7374

7475
msHost := cliCtx.Dev.Microshift.Host
7576
if msHost == "" {
76-
ctrl.Log.Error(errMissingArg, "Host must be set in `microshift` section of the configuration")
77-
os.Exit(1)
77+
msHost = defaultHost
78+
ctrl.Log.Info("Host not set, defaulting to " + defaultHost)
7879
}
7980
msUser := cliCtx.Dev.Microshift.User
8081
if msUser == "" {
@@ -84,14 +85,15 @@ func createMicroshift(kmd *cobra.Command, cliCtx cliutils.SoftwareFactoryConfigC
8485
}
8586
msOpenshiftPullSecret := cliCtx.Dev.Microshift.OpenshiftPullSecret
8687
if msOpenshiftPullSecret == "" {
87-
ctrl.Log.Error(errMissingArg, "A valid OpenShift pull secret must be set in `microshift` section of the configuration file")
88-
os.Exit(1)
88+
msOpenshiftPullSecret = "not-a-valid-pull-secret"
89+
ctrl.Log.Info("A valid OpenShift pull secret must be set in `microshift` section of the configuration file")
8990
}
9091
msDiskFileSize := cliCtx.Dev.Microshift.DiskFileSize
9192
if msDiskFileSize == "" {
9293
msDiskFileSize = defaultDiskSpace
9394
ctrl.Log.Info("disk-file-size not set, defaulting to " + defaultDiskSpace)
9495
}
96+
msEtcdOnRamdisk := cliCtx.Dev.Microshift.ETCDOnRAMDisk
9597
msAnsibleMicroshiftRolePath := cliCtx.Dev.AnsibleMicroshiftRolePath
9698
if msAnsibleMicroshiftRolePath == "" {
9799
msAnsibleMicroshiftRolePath = rootDir + "/ansible-microshift-role"
@@ -104,7 +106,8 @@ func createMicroshift(kmd *cobra.Command, cliCtx cliutils.SoftwareFactoryConfigC
104106
}
105107

106108
options := ms.MkAnsiblePlaybookOptions(msHost, msUser, msOpenshiftPullSecret, rootDir)
107-
varsFile := ms.MkTemporaryVarsFile(cliCtx.FQDN, msDiskFileSize, msAnsibleMicroshiftRolePath, rootDir)
109+
varsFile := ms.MkTemporaryVarsFile(
110+
cliCtx.FQDN, msDiskFileSize, msAnsibleMicroshiftRolePath, rootDir, msEtcdOnRamdisk)
108111
options.ExtraVarsFile = []string{"@" + varsFile}
109112
// Ensure ansible-microshift-role is available
110113
ms.MkMicroshiftRoleSetupPlaybook(rootDir)

cli/cmd/dev/microshift/microshift.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type GroupVarsData struct {
4848
FQDN string
4949
DiskFileSize string
5050
MicroshiftRolePath string
51+
ETCDOnRAMDisk bool
5152
}
5253

5354
type PlayBook struct {
@@ -114,11 +115,13 @@ func MkAnsiblePlaybookOptions(host string, user string, pullSecret string, rootD
114115
}
115116
}
116117

117-
func MkTemporaryVarsFile(fqdn string, diskFileSize string, microshiftRolePath string, rootDir string) string {
118+
func MkTemporaryVarsFile(
119+
fqdn string, diskFileSize string, microshiftRolePath string, rootDir string, etcdOnRamdisk bool) string {
118120
varsData := GroupVarsData{
119121
fqdn,
120122
diskFileSize,
121123
microshiftRolePath,
124+
etcdOnRamdisk,
122125
}
123126
filePath := rootDir + "/all.yaml"
124127
template, err := cutils.ParseString(groupvars, varsData)

cli/cmd/dev/microshift/static/all.yaml.tmpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ microshift_fqdn: microshift.dev
44
sf_fqdn: {{ .FQDN }}
55
disk_file_sparsed: true
66
disk_file_size: {{ .DiskFileSize }}
7+
etcd_on_ramdisk: {{ .ETCDOnRAMDisk }}
78
setup_olm: true
89
microshift_additional_addresses:
910
- {{ "\"{{ microshift_fqdn }}\"" }}

cli/cmd/utils/utils.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ type SoftwareFactoryConfigContext struct {
7171
User string `json:"user" mapstructure:"user"`
7272
OpenshiftPullSecret string `json:"openshift-pull-secret" mapstructure:"openshift-pull-secret"`
7373
DiskFileSize string `json:"disk-file-size" mapstructure:"disk-file-size"`
74+
ETCDOnRAMDisk bool `json:"etcd-on-ramdisk" mapstructure:"etcd-on-ramdisk"`
7475
} `json:"microshift" mapstructure:"microshift"`
7576
Tests struct {
7677
DemoReposPath string `json:"demo-repos-path" mapstructure:"demo-repos-path"`

0 commit comments

Comments
 (0)