fix codeql warning and error (#192)

Author: xuan-cao-swi

.rubocop.yml

@@ -52,3 +52,6 @@ Metrics/BlockNesting:
 Lint/ConstantDefinitionInBlock:
   Exclude:
     - 'test/api/custom_instrumentation_test.rb'
+Style/StringLiterals:
+  Exclude:
+    - 'Gemfile'

gemfiles/test_gems.gemfile

@@ -46,8 +46,6 @@ group :development, :test do
 
   gem 'opentelemetry-resource-detector-azure'
   # aws resource detector requires ruby >= 3.1.0
-  if RUBY_VERSION >= '3.1.0'
-    gem 'opentelemetry-resource-detector-aws'
-  end
+  gem 'opentelemetry-resource-detector-aws' if RUBY_VERSION >= '3.1.0'
   gem 'opentelemetry-resource-detector-container'
 end

lib/solarwinds_apm/api/current_trace_info.rb

@@ -111,12 +111,16 @@ def hash_for_log
         private
 
         def current_span
-          span     = ::OpenTelemetry::Trace.current_span if defined?(::OpenTelemetry::Trace)
-          trace_id = span.context.hex_trace_id
-          span_id  = span.context.hex_span_id
-          trace_flags = span.context.trace_flags.sampled? ? '01' : '00'
-          tracestring = "00-#{trace_id}-#{span_id}-#{trace_flags}"
-          [trace_id, span_id, trace_flags, tracestring]
+          if defined?(::OpenTelemetry::Trace)
+            span     = ::OpenTelemetry::Trace.current_span
+            trace_id = span.context.hex_trace_id
+            span_id  = span.context.hex_span_id
+            trace_flags = span.context.trace_flags.sampled? ? '01' : '00'
+            tracestring = "00-#{trace_id}-#{span_id}-#{trace_flags}"
+            [trace_id, span_id, trace_flags, tracestring]
+          else
+            %w[00000000000000000000000000000000 00000000 00 00-00000000000000000000000000000000-00000000-00]
+          end
         end
 
         # if true the trace info should be added to the log message

lib/solarwinds_apm/opentelemetry/otlp_processor.rb

@@ -108,8 +108,7 @@ def calculate_transaction_names(span)
           trans_name = span.attributes[HTTP_ROUTE] || nil
           trans_name = span.name if trans_name.to_s.empty? && span.name
         end
-        trans_name = trans_name.to_s.slice(0, SolarWindsAPM::Constants::MAX_TXN_NAME_LENGTH)
-        trans_name
+        trans_name.to_s.slice(0, SolarWindsAPM::Constants::MAX_TXN_NAME_LENGTH)
       end
 
       def record_request_metrics(span)