Skip to content

Commit 72e1d58

Browse files
authored
Merge pull request #152 from solarwinds/NH-89983
NH-89983: remove doc/ from lambda build; fix logging
2 parents bc36931 + afe2cfd commit 72e1d58

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

lambda/otel/Dockerfile_3_2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ RUN export gem_file=$(cat gem_file.txt) && \
2020
bundle update; \
2121
fi
2222

23-
RUN rm /build/layer/ruby/ruby/3.2.0/cache/*
23+
RUN rm /build/layer/ruby/ruby/3.2.0/cache/* && rm -rf /build/layer/ruby/ruby/3.2.0/doc/*
2424

2525
WORKDIR /build/layer/ruby/ruby
2626
RUN zip -qr gems-3.2.0.zip 3.2.0/

lambda/otel/Dockerfile_3_3

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ RUN export gem_file=$(cat gem_file.txt) && \
2020
bundle update; \
2121
fi
2222

23-
RUN rm /build/layer/ruby/ruby/3.3.0/cache/*
23+
RUN rm /build/layer/ruby/ruby/3.3.0/cache/* && rm -rf /build/layer/ruby/ruby/3.3.0/doc/*
2424

2525
WORKDIR /build/layer/ruby/ruby
2626
RUN zip -qr gems-3.3.0.zip 3.3.0/

lambda/otel/layer/otel_wrapper.rb

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def preload_function_dependencies
1515

1616
unless handler_file && File.exist?("#{default_task_location}/#{handler_file}.rb")
1717
OpenTelemetry.logger.warn { 'Could not find the original handler file to preload libraries.' }
18-
return
18+
return nil
1919
end
2020

2121
libraries = File.read("#{default_task_location}/#{handler_file}.rb")
@@ -27,11 +27,16 @@ def preload_function_dependencies
2727
rescue StandardError => e
2828
OpenTelemetry.logger.warn { "Could not load library #{lib}: #{e.message}" }
2929
end
30+
handler_file
3031
end
3132

32-
unless ENV['SW_APM_LAMBDA_PRELOAD_DEPS'].to_s.downcase == 'false'
33+
if ENV['SW_APM_LAMBDA_PRELOAD_DEPS'].to_s.downcase == 'false'
3334
OpenTelemetry.logger.warn { "SW_APM_LAMBDA_PRELOAD_DEPS set to #{ENV.fetch('SW_APM_LAMBDA_PRELOAD_DEPS', nil)}. No libraries will be preloaded." }
34-
preload_function_dependencies
35+
else
36+
37+
handler_file = preload_function_dependencies
38+
39+
OpenTelemetry.logger.info { "Libraries in #{handler_file} have been preloaded." } if handler_file
3540

3641
require 'opentelemetry-registry'
3742
require 'opentelemetry-instrumentation-all'

0 commit comments

Comments
 (0)