lint

Author: xuan-cao-swi

.rubocop.yml

@@ -55,3 +55,5 @@ Lint/ConstantDefinitionInBlock:
 Style/StringLiterals:
   Exclude:
     - 'Gemfile'
+Naming/PredicateMethod:
+  Enabled: false

lib/solarwinds_apm/support/resource_detector/aws/ecs.rb

@@ -134,12 +134,12 @@ def merge_metadata(attribute, container_metadata, task_metadata)
 
       def get_account_id_from_arn(task_arn)
         matches = task_arn.to_s.match(/arn:aws:ecs:[^:]+:([^:]+):.*/)
-        matches ? matches[1] : nil
+        matches.nil? ? matches[1] : nil
       end
 
       def get_region_from_arn(task_arn)
         matches = task_arn.to_s.match(/arn:aws:ecs:([^:]+):.*/)
-        matches ? matches[1] : nil
+        matches.nil? ? matches[1] : nil
       end
 
       def get_url_as_json(url)