Skip to content

Commit fd0ff1a

Browse files
committed
fix some issue
1 parent 07290e4 commit fd0ff1a

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

lib/solarwinds_apm/api/tracing.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module Tracing
2828
# === Returns:
2929
# * Boolean
3030
#
31-
def solarwinds_ready?(wait_milliseconds = 3000, integer_response: false)
31+
def solarwinds_ready?(wait_milliseconds = 3000, integer_response: nil)
3232
unless integer_response.nil?
3333
SolarWindsAPM.logger.warn do
3434
'Deprecation: solarwinds_ready? no longer accepts integer_response, this parameter will be removed in the next release.'

lib/solarwinds_apm/opentelemetry/otlp_processor.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def on_start(span, parent_context)
4747
def on_finishing(span)
4848
@transaction_name = calculate_transaction_names(span)
4949
span.set_attribute(SW_TRANSACTION_NAME, @transaction_name)
50-
# pp span
5150
@txn_manager.delete_root_context_h(span.context.hex_trace_id)
5251
end
5352

lib/solarwinds_apm/sampling.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,6 @@
2424
require_relative 'sampling/sampler'
2525
require_relative 'sampling/http_sampler'
2626
require_relative 'sampling/json_sampler'
27+
28+
# Patching
29+
require_relative 'sampling/sampling_patch'

lib/solarwinds_apm/sampling/sampling_patch.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,6 @@ def finish(end_timestamp: nil)
4444
end
4545

4646
OpenTelemetry::Exporter::OTLP::Metrics::MetricsExporter.prepend(SolarWindsAPM::MetricsExporter::Patch)
47+
48+
# issue: https://github.com/open-telemetry/opentelemetry-ruby/issues/1824
4749
OpenTelemetry::SDK::Trace::Span.prepend(SolarWindsAPM::Span::Patch)

0 commit comments

Comments
 (0)