Skip to content

refactor debug msg #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor debug msg #143

wants to merge 1 commit into from

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Aug 19, 2024 •
edited
Loading

Description

  1. Add a warn log to indicate that user's manual initialization success
  2. Reduce the duplicate debug msg from context where the same current-span context show up twice.
  3. Use span.to_span_data for more clear debug msg.

Test (if applicable)

Failed test on ruby 2.7.5 will be fixed in #142

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner August 19, 2024 16:56
jerrytfleung
jerrytfleung approved these changes Aug 19, 2024
View reviewed changes
Copy link

@jerrytfleung jerrytfleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuan-cao-swi
Copy link
Contributor Author

Close this PR, will continue the work in NH-89218

@xuan-cao-swi xuan-cao-swi deleted the refactor-debug-msg branch August 23, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrytfleung jerrytfleung jerrytfleung approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuan-cao-swi @jerrytfleung