Skip to content

Conversation

xuan-cao-swi
Copy link
Contributor

Description

Test (if applicable)

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner March 10, 2025 15:43
cheempz
cheempz previously approved these changes Mar 10, 2025
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment on reusing the version instead of re-extracting in scanning jobs.

steps:
- uses: actions/checkout@v4

- name: extract current solarwinds_apm version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, seems you should be able to pass the version info from previous job to this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated for github package and rubygems

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 82ee0e2 into main Mar 19, 2025
14 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-103804 branch March 19, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants