Skip to content

NH-110422: remove c extension and related test #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

NH-110422: remove c extension and related test #189

merged 2 commits into from
May 13, 2025

Conversation

xuan-cao-swi
Copy link
Contributor

Description

Test (if applicable)

@xuan-cao-swi xuan-cao-swi marked this pull request as ready for review May 12, 2025 17:06
@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner May 12, 2025 17:06
cheempz
cheempz reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should add back the init tests that check for:

  • SW_APM_ENABLED=false should still not load the library and ensure no-op behaviour
  • SW_APM_SERVICE_KEY missing or invalid format should also still not load the library and ensure no-opt behaviour

@xuan-cao-swi xuan-cao-swi requested a review from cheempz May 13, 2025 18:45
cheempz
cheempz approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 2de543b into pure-otel-ruby May 13, 2025
9 of 10 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-110422 branch June 9, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuan-cao-swi @cheempz