Fix release action #158
Open
Fix release action #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Thanks @prettycoder, changes LGTM but I do have a question about the "create GH Release" step.
| -X POST \ | ||
| -H "Accept: application/vnd.github.v3+json" \ | ||
| https://api.github.com/repos/OWNER/REPO/releases \ | ||
| -d '{"tag_name":"${{ steps.build.outputs.gem_version }}","name":"${{ steps.build.outputs.gem_version }}","body":"SHA256 checksum: ${{ steps.build.outputs.checksum }}","draft":true}' |
There was a problem hiding this comment.
AFAICT actions/github-script is still maintained by GHA, so wondering why this change? Also, how are credentials being given by curl when making the call to GH API, and are OWNER/REPO getting set correctly?
There was a problem hiding this comment.
the create_release script is not maintained anymore and not working anymore
When I wrote the release notes I realized that this version is not working either, but it doesn't fail the action
Let me see if I can fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.