Skip to content

Commit cdea000

Browse files
committed
Used time.RFC3339 format
1 parent 2d33076 commit cdea000

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

collector/receiver/telemetryapireceiver/receiver.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import (
4242
)
4343

4444
const initialQueueSize = 5
45-
const timeFormatLayout = "2006-01-02T15:04:05.000Z"
4645
const scopeName = "github.com/open-telemetry/opentelemetry-lambda/collector/receiver/telemetryapi"
4746

4847
type telemetryAPIReceiver struct {
@@ -194,7 +193,7 @@ func (r *telemetryAPIReceiver) createLogs(slice []event) (plog.Logs, error) {
194193
r.logger.Debug(fmt.Sprintf("Event: %s", el.Type), zap.Any("event", el))
195194
logRecord := scopeLog.LogRecords().AppendEmpty()
196195
logRecord.Attributes().PutStr("type", el.Type)
197-
if t, err := time.Parse(timeFormatLayout, el.Time); err == nil {
196+
if t, err := time.Parse(time.RFC3339, el.Time); err == nil {
198197
logRecord.SetTimestamp(pcommon.NewTimestampFromTime(t))
199198
logRecord.SetObservedTimestamp(pcommon.NewTimestampFromTime(time.Now()))
200199
} else {
@@ -205,7 +204,7 @@ func (r *telemetryAPIReceiver) createLogs(slice []event) (plog.Logs, error) {
205204
if record, ok := el.Record.(map[string]interface{}); ok {
206205
// in JSON format https://docs.aws.amazon.com/lambda/latest/dg/telemetry-schema-reference.html#telemetry-api-function
207206
if timestamp, ok := record["timestamp"].(string); ok {
208-
if t, err := time.Parse(timeFormatLayout, timestamp); err == nil {
207+
if t, err := time.Parse(time.RFC3339, timestamp); err == nil {
209208
logRecord.SetTimestamp(pcommon.NewTimestampFromTime(t))
210209
} else {
211210
r.logger.Error("error parsing time", zap.Error(err))
@@ -290,12 +289,12 @@ func (r *telemetryAPIReceiver) createPlatformInitSpan(start, end string) (ptrace
290289
span.SetName("platform.initRuntimeDone")
291290
span.SetKind(ptrace.SpanKindInternal)
292291
span.Attributes().PutBool(semconv.AttributeFaaSColdstart, true)
293-
startTime, err := time.Parse(timeFormatLayout, start)
292+
startTime, err := time.Parse(time.RFC3339, start)
294293
if err != nil {
295294
return ptrace.Traces{}, err
296295
}
297296
span.SetStartTimestamp(pcommon.NewTimestampFromTime(startTime))
298-
endTime, err := time.Parse(timeFormatLayout, end)
297+
endTime, err := time.Parse(time.RFC3339, end)
299298
if err != nil {
300299
return ptrace.Traces{}, err
301300
}

collector/receiver/telemetryapireceiver/receiver_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ func TestCreateLogs(t *testing.T) {
334334
attr, ok := logRecord.Attributes().Get("type")
335335
require.True(t, ok)
336336
require.Equal(t, tc.expectedType, attr.Str())
337-
expectedTime, err := time.Parse(timeFormatLayout, tc.expectedTimestamp)
337+
expectedTime, err := time.Parse(time.RFC3339, tc.expectedTimestamp)
338338
require.NoError(t, err)
339339
require.Equal(t, pcommon.NewTimestampFromTime(expectedTime), logRecord.Timestamp())
340340
requestId, ok := logRecord.Attributes().Get(semconv.AttributeFaaSInvocationID)

0 commit comments

Comments
 (0)