Update FieldRef classes #1519
Open
Update FieldRef classes #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tim-hoffman
commented
Jan 5, 2021
tim-hoffman
commented
- formatting and cleanup
- caching of the resolved SootField in AbstractSootFieldRef because it can be an expensive operation
Member
|
@swissiety can you review this ? |
swissiety
reviewed
Jun 7, 2021
Member
|
@swissiety Is this PR ready for merging? |
Collaborator
|
@linghuiluo that depends on whether we want a SootField caching mechanism that works globally instead of locally per FieldRef as it is introduced in this PR |
Member
Author
|
Regardless, local caching does provide an improvement. Changing to global caching could be considered separately in the future. |
linghuiluo
reviewed
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.