Skip to content

Clarify error messages in FieldRefValidator #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Clarify error messages in FieldRefValidator #1653

wants to merge 4 commits into from

Conversation

@tim-hoffman
Copy link
Member

@tim-hoffman tim-hoffman commented Jun 9, 2021

No description provided.

linghuiluo
linghuiluo reviewed Jun 28, 2021
View reviewed changes
linghuiluo
linghuiluo reviewed Jun 28, 2021
View reviewed changes
@tim-hoffman
Copy link
Member Author

tim-hoffman commented Jun 29, 2021 •
edited
Loading

@linghuiluo I've made some significant changes so that this could also handle BafBody instances and removed some of the duplication that was there (with multiple try-catch for instance).
Perhaps we should have a unit test for this validator as well. I don't think one exists.

@linghuiluo
Copy link
Member

linghuiluo commented Jun 30, 2021

@linghuiluo I've made some significant changes so that this could also handle BafBody instances and removed some of the duplication that was there (with multiple try-catch for instance).
Perhaps we should have a unit test for this validator as well. I don't think one exists.

thanks, your implementation looks nice. yeah, I agree, some unit tests would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linghuiluo linghuiluo linghuiluo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tim-hoffman @linghuiluo