Skip to content

CSE machine: animation of spread operator #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martin-henz opened this issue Mar 5, 2025 · 2 comments
Open

CSE machine: animation of spread operator #3110

martin-henz opened this issue Mar 5, 2025 · 2 comments
Labels
Enhancement New feature request minor Less important than important, but more than nice-to-have

Comments

@martin-henz
Copy link
Member

As indicated in #3103

It would be nice to highlight the change of the arity in the CALL instruction using animation.
@martin-henz martin-henz added Enhancement New feature request minor Less important than important, but more than nice-to-have labels Mar 5, 2025
@alsonleej
Copy link
Contributor

also, [1][2] (array access out of bounds) should push undefined to stash as per Source 4 spec. after implementing in source-academy/js-slang#1750, the animation is still undone (because the "box" has no where to move to)

@alsonleej alsonleej mentioned this issue Mar 12, 2025
Open
3 tasks
@alsonleej
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature request minor Less important than important, but more than nice-to-have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martin-henz @alsonleej