Sessions Overhaul

[TheMythologist]

Description

CP3108 Project by @salmonkarp and myself
Fixes sessions, as well as better session integration with changes to sessions backend

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Code quality improvements

Linked to source-academy/sharedb-ace#30 and source-academy/sharedb-ace-backend#33

[RichDom2185]

@TheMythologist sorry for the delay, there's still a type error on UseShareAce (even though last I checked using a locally-linked version, everything was fine). Could you check?

[TheMythologist]

Hi, seems like events-emitter-es6 was causing problems. Switched that package for node:events. Created a PR fix here: source-academy/sharedb-ace#32

Let me know once the new package is published, I will bump the version of @sourceacademy/sharedb-ace and hopefully there won't be any more type errors

[TheMythologist]

Hi sorry to bother Prof @martin-henz, but could you help to bump the @sourceacademy/sharedb-ace again? Bump it to 2.1.1 (it's already updated in the package.json file)

[martin-henz]

Hi sorry to bother Prof @martin-henz, but could you help to bump the @sourceacademy/sharedb-ace again? Bump it to 2.1.1 (it's already updated in the package.json file)

OK done.

[TheMythologist]

Sorry prof @martin-henz, requesting you to bump the @sourceacademy/sharedb-ace again one last time, to 2.1.2 (it's already updated in the package.json file).

[TheMythologist]

Sorry prof @martin-henz, bumping again

[RichDom2185]

@TheMythologist Sorry for the delay, seems like ShareDB is CJS but our package is CJS so we can't import it? Can we publish a CJS (or dual) version instead?

[RichDom2185]

It seems like we are already publishing a dual CJS-ESM package, hmm why is the test failing

[sayomaki]

Will revert and use @sourceacademy/sharedb-ace 2.1.1 instead.

[sayomaki]

Looks good to me, thanks for the working on this!

[coveralls]

Pull Request Test Coverage Report for Build 16847084480

Details

• 206 of 531 (38.79%) changed or added relevant lines in 19 files are covered.
• 8 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.1%) to 43.281%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/features/sourceRecorder/sourcereel/SourcereelReducer.ts	2	3	66.67%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx	0	2	0.0%
src/pages/playground/Playground.tsx	25	28	89.29%
src/commons/collabEditing/CollabEditingActions.ts	8	14	57.14%
src/commons/workspace/WorkspaceReducer.ts	4	17	23.53%
src/commons/collabEditing/CollabEditingHelper.ts	2	19	10.53%
src/commons/controlBar/ControlBarSessionButton.tsx	81	125	64.8%
src/commons/utils/AceHelper.ts	2	58	3.45%
src/commons/editor/UseShareAce.tsx	30	92	32.61%
src/commons/sideContent/content/SideContentSessionManagement.tsx	15	136	11.03%

Files with Coverage Reduction	New Missed Lines	%
src/commons/collabEditing/CollabEditingActions.ts	1	74.29%
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx	1	0.0%
src/commons/controlBar/ControlBarSessionButton.tsx	2	58.94%
src/commons/editor/UseShareAce.tsx	2	45.86%
src/commons/workspace/WorkspaceReducer.ts	2	74.93%

Totals
Change from base Build 16846397326:	-0.1%
Covered Lines:	20529
Relevant Lines:	49615

---

💛 - Coveralls

[RichDom2185]

LGTM, thanks!