Skip to content

Conversation

@akshatdubeysf
Copy link
Contributor

Description

This pull request includes several changes to enhance the Kafka client for Loopback4, focusing on supporting more flexible consumer configurations and improving test coverage. The most important changes include the introduction of new consumer interfaces, updates to the Kafka consumer service, and modifications to the test suite to reflect these changes.

Enhancements to consumer configurations:

  • Updated the README.md to include new consumer interfaces: IConsumer, ISharedConsumer, and IGenericConsumer, and provided detailed descriptions and examples for each.
  • Introduced a new decorator genericConsumer for easier binding of generic consumers. [1] [2]

Updates to Kafka consumer service:

  • Modified KafkaConsumerService to handle generic consumers and their configurations, ensuring they are always run if specified. [1] [2]

Test suite improvements:

  • Added a new GenericStream interface and updated existing test fixtures to use it. [1] [2]
  • Updated the acceptance tests to validate the behavior of generic consumers. [1] [2]

Codebase simplification:

  • Removed redundant type definitions and streamlined the handler types for generic consumers. [1] [2]

These changes collectively enhance the flexibility and robustness of the Kafka client, making it easier to configure and test various consumer scenarios.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@sonarqubecloud
Copy link

Copy link
Contributor

@a-ganguly a-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apprved

@a-ganguly a-ganguly merged commit 0b6d025 into master Dec 27, 2024
7 checks passed
@yeshamavani
Copy link
Contributor

🎉 This PR is included in version 3.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants