From 01ce4c18a2af85673d6d3048fc51ac7c2d3c3c4c Mon Sep 17 00:00:00 2001 From: Sourcegraph Bot Date: Tue, 28 Apr 2020 15:58:19 +0000 Subject: [PATCH] Use t.Cleanup instead of defer in Golang code tests --- jsonrpc2_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jsonrpc2_test.go b/jsonrpc2_test.go index 9710ab5..9aea301 100644 --- a/jsonrpc2_test.go +++ b/jsonrpc2_test.go @@ -121,7 +121,7 @@ func TestClientServer(t *testing.T) { if err != nil { t.Fatal("Listen:", err) } - defer func() { + t.Cleanup(func() { if lis == nil { return // already closed } @@ -130,7 +130,7 @@ func TestClientServer(t *testing.T) { t.Fatal(err) } } - }() + }) ha := testHandlerA{t: t} go func() { @@ -184,11 +184,11 @@ func TestClientServer(t *testing.T) { func testClientServer(ctx context.Context, t *testing.T, stream jsonrpc2.ObjectStream) { hb := testHandlerB{t: t} cc := jsonrpc2.NewConn(ctx, stream, &hb) - defer func() { + t.Cleanup(func() { if err := cc.Close(); err != nil { t.Fatal(err) } - }() + }) // Simple const n = 100