Incorrect use of url argument in browser extension eventlogger

[dadlerj]

The url argument to telemetryservice/eventlogger calls should represent the current URL in which the event occurs. For telemetryservices/eventloggers running in the webapp, for example, it's whatever the window.location.host is when the event fires.

I was browsing the bext eventlogger code just now, and I noticed that we seem to be passing the sourcegraphURL in for this argument, which represents something different (I think). My impression is that the sourcegraphURL value represents the URL of the Sourcegraph instance that the bext is connected to at that moment in time.

For event logs from the bext, I think it's appropriate to send null or an empty string for the url argument to eventlogger (instead of the actual github/code host URL).

• https://sourcegraph.com/github.com/sourcegraph/sourcegraph@main/-/blob/client/browser/src/shared/tracking/eventLogger.tsx?L124
• https://sourcegraph.com/github.com/sourcegraph/sourcegraph@main/-/blob/client/browser/src/shared/tracking/eventLogger.tsx?L130

[github-actions]

Heads up @muratsu @rrhyne @jjinnii @ryankscott - the "team/growth-and-integrations" label was applied to this issue.

[dadlerj]

(I might be totally incorrect in my reading here, this code has evolved a lot since I last touched it, feel free to close this out if so)

[erzhtor]

Thanks for reporting, @dadlerj! I agree with you that logically it will always be the same as the instance URL since bext sends to it. However, based on git history, we have always been sending it, and I'm not sure how it will affect events/analytics/pings.

So, it would be great if anyone from the analytics team could confirm that it is safe to remove and pass null/empty instead?

cc @sourcegraph/bizops