style: various code smells

Author: soyuka

features/graphql/authorization.feature

@@ -410,7 +410,7 @@ Feature: Authorization checking
     """
     Then the response status code should be 200
     And the response should be in JSON
-    And the JSON node "data.securedDummy.ownerOnlyProperty" should be equal to the string ""
+    And the JSON node "data.securedDummy.ownerOnlyProperty" should be equal to ""
 
   Scenario: A user cannot retrieve an item they doesn't own
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="

features/main/custom_operation.feature

@@ -96,7 +96,7 @@ Feature: Custom operation
 
   @createSchema
   Scenario: Void a payment
-    Given There is a payment
+    Given there is a payment
     When I send a "POST" request to "/payments/1/void"
     Then the response status code should be 201
     And the response should be in JSON

src/Action/ExceptionAction.php

@@ -85,12 +85,13 @@ private function getOperationExceptionToStatus(Request $request): array
         $resourceMetadataCollection = $this->resourceMetadataCollectionFactory->create($attributes['resource_class']);
         /** @var HttpOperation $operation */
         $operation = $resourceMetadataCollection->getOperation($attributes['operation_name'] ?? null);
-        $exceptionToStatus = $operation->getExceptionToStatus() ?: [];
+        $exceptionToStatus = [$operation->getExceptionToStatus() ?: []];
+
         foreach ($resourceMetadataCollection as $resourceMetadata) {
-            /** @var ApiResource $resourceMetadata */
-            $exceptionToStatus = array_merge($exceptionToStatus, $resourceMetadata->getExceptionToStatus() ?: []);
+            /* @var ApiResource $resourceMetadata */
+            $exceptionToStatus[] = $resourceMetadata->getExceptionToStatus() ?: [];
         }
 
-        return $exceptionToStatus;
+        return array_merge(...$exceptionToStatus);
     }
 }

src/Api/IdentifiersExtractor.php

@@ -75,7 +75,8 @@ public function getIdentifiersFromItem(object $item, Operation $operation = null
                 continue;
             }
 
-            $identifiers[$link->getParameterName()] = $this->getIdentifierValue($item, $link->getFromClass(), $link->getIdentifiers()[0], $link->getParameterName());
+            $parameterName = $link->getParameterName();
+            $identifiers[$parameterName] = $this->getIdentifierValue($item, $link->getFromClass(), $link->getIdentifiers()[0], $parameterName);
         }
 
         return $identifiers;

src/Api/QueryParameterValidator/QueryParameterValidator.php

@@ -61,13 +61,15 @@ public function validateFilters(string $resourceClass, array $resourceFilters, a
 
             foreach ($filter->getDescription($resourceClass) as $name => $data) {
                 foreach ($this->validators as $validator) {
-                    $errorList = array_merge($errorList, $validator->validate($name, $data, $queryParameters));
+                    if ($errors = $validator->validate($name, $data, $queryParameters)) {
+                        $errorList[] = $errors;
+                    }
                 }
             }
         }
 
         if ($errorList) {
-            throw new FilterValidationException($errorList);
+            throw new FilterValidationException(array_merge(...$errorList));
         }
     }
 }

src/Doctrine/Common/State/LinksHandlerTrait.php

@@ -53,9 +53,9 @@ private function getLinks(string $resourceClass, Operation $operation, array $co
 
             // Instead, we'll look for the first Query available.
             foreach ($resourceMetadataCollection as $resourceMetadata) {
-                foreach ($resourceMetadata->getGraphQlOperations() as $operation) {
-                    if ($operation instanceof Query) {
-                        $linkedOperation = $operation;
+                foreach ($resourceMetadata->getGraphQlOperations() as $op) {
+                    if ($op instanceof Query) {
+                        $linkedOperation = $op;
                     }
                 }
             }

src/GraphQl/Action/EntrypointAction.php

@@ -156,7 +156,7 @@ private function applyMapToVariables(array $map, array $variables, array $files)
                 throw new BadRequestHttpException('GraphQL multipart request file has not been sent correctly.');
             }
 
-            foreach ($map[$key] as $mapValue) {
+            foreach ($value as $mapValue) {
                 $path = explode('.', (string) $mapValue);
 
                 if ('variables' !== $path[0]) {

src/GraphQl/Serializer/SerializerContextBuilder.php

@@ -88,7 +88,7 @@ private function replaceIdKeys(array $fields, ?string $resourceClass, array $con
                 continue;
             }
 
-            $denormalizedFields[$this->denormalizePropertyName((string) $key, $resourceClass, $context)] = \is_array($fields[$key]) ? $this->replaceIdKeys($fields[$key], $resourceClass, $context) : $value;
+            $denormalizedFields[$this->denormalizePropertyName((string) $key, $resourceClass, $context)] = \is_array($value) ? $this->replaceIdKeys($value, $resourceClass, $context) : $value;
         }
 
         return $denormalizedFields;

src/Metadata/Property/Factory/SerializerPropertyMetadataFactory.php

@@ -198,9 +198,9 @@ private function getClassSerializerGroups(string $class): array
 
         $groups = [];
         foreach ($serializerClassMetadata->getAttributesMetadata() as $serializerAttributeMetadata) {
-            $groups = array_merge($groups, $serializerAttributeMetadata->getGroups());
+            $groups[] = $serializerAttributeMetadata->getGroups();
         }
 
-        return array_unique($groups);
+        return array_unique(array_merge(...$groups));
     }
 }

src/Serializer/AbstractItemNormalizer.php

@@ -263,7 +263,7 @@ protected function instantiateObject(array &$data, string $class, array &$contex
                             throw new RuntimeException(sprintf('Cannot create an instance of %s from serialized data because the variadic parameter %s can only accept an array.', $class, $constructorParameter->name));
                         }
 
-                        $params = array_merge($params, $data[$paramName]);
+                        $params[] = $data[$paramName];
                     }
                 } elseif ($allowed && !$ignored && (isset($data[$key]) || \array_key_exists($key, $data))) {
                     $params[] = $this->createConstructorArgument($data[$key], $key, $constructorParameter, $context, $format);

src/Symfony/Routing/ApiLoader.php

@@ -75,10 +75,8 @@ public function load(mixed $data, string $type = null): RouteCollection
                         $path = str_replace(sprintf('{%s}', $parameterName), $expandedValue, $path);
                     }
 
-                    if ($controller = $operation->getController()) {
-                        if (!$this->container->has($controller)) {
-                            throw new RuntimeException(sprintf('There is no builtin action for the "%s" operation. You need to define the controller yourself.', $operationName));
-                        }
+                    if (($controller = $operation->getController()) && !$this->container->has($controller)) {
+                        throw new RuntimeException(sprintf('There is no builtin action for the "%s" operation. You need to define the controller yourself.', $operationName));
                     }
 
                     $route = new Route(

tests/Fixtures/TestBundle/Entity/SubresourceOrganization.php

@@ -75,11 +75,9 @@ public function addSubresourceEmployee(SubresourceEmployee $employee): self
 
     public function removeSubresourceEmployee(SubresourceEmployee $employee): self
     {
-        if ($this->employees->removeElement($employee)) {
-            // set the owning side to null (unless already changed)
-            if ($employee->getSubresourceOrganization() === $this) {
-                $employee->setSubresourceOrganization(null);
-            }
+        // set the owning side to null (unless already changed)
+        if ($this->employees->removeElement($employee) && $employee->getSubresourceOrganization() === $this) {
+            $employee->setSubresourceOrganization(null);
         }
 
         return $this;

tests/Fixtures/TestBundle/GraphQl/Resolver/UploadMultipleMediaObjectResolver.php

@@ -26,7 +26,6 @@ class UploadMultipleMediaObjectResolver implements MutationResolverInterface
 {
     public function __invoke(?object $item, array $context): MediaObject
     {
-        $result = [];
         $mediaObject = null;
 
         /**
@@ -40,7 +39,6 @@ public function __invoke(?object $item, array $context): MediaObject
             $mediaObject = new MediaObject();
             $mediaObject->id = $key;
             $mediaObject->contentUrl = $uploadedFile->getFilename();
-            $result[] = $mediaObject;
         }
 
         // Currently API Platform does not support custom mutation with collections so for now, we are returning the last created media object.