fix php 7 lowest

Author: soyuka

.github/workflows/ci.yml

@@ -7,6 +7,7 @@ on:
 env:
   COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   COVERAGE: '0'
+  SYMFONY_DEPRECATIONS_HELPER: 'disabled=1'
 
 jobs:
   php-cs-fixer:
@@ -151,30 +152,30 @@ jobs:
           else
             vendor/bin/simple-phpunit --log-junit build/logs/phpunit/junit.xml
           fi
-      # - name: Upload test artifacts
-      #   if: always()
-      #   uses: actions/upload-artifact@v1
-      #   with:
-      #     name: phpunit-logs-php${{ matrix.php }}
-      #     path: build/logs/phpunit
-      #   continue-on-error: true
-      # - name: Upload coverage results to Codecov
-      #   if: matrix.coverage
-      #   uses: codecov/codecov-action@v1
-      #   with:
-      #     name: phpunit-php${{ matrix.php }}
-      #     flags: phpunit
-      #     fail_ci_if_error: true
-      #   continue-on-error: true
-      # - name: Upload coverage results to Coveralls
-      #   if: matrix.coverage
-      #   env:
-      #     COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #   run: |
-      #     composer global require --prefer-dist --no-interaction --no-progress --ansi cedx/coveralls
-      #     export PATH="$PATH:$HOME/.composer/vendor/bin"
-      #     coveralls build/logs/phpunit/clover.xml
-      #   continue-on-error: true
+      - name: Upload test artifacts
+        if: always()
+        uses: actions/upload-artifact@v1
+        with:
+          name: phpunit-logs-php${{ matrix.php }}
+          path: build/logs/phpunit
+        continue-on-error: true
+      - name: Upload coverage results to Codecov
+        if: matrix.coverage
+        uses: codecov/codecov-action@v1
+        with:
+          name: phpunit-php${{ matrix.php }}
+          flags: phpunit
+          fail_ci_if_error: true
+        continue-on-error: true
+      - name: Upload coverage results to Coveralls
+        if: matrix.coverage
+        env:
+          COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          composer global require --prefer-dist --no-interaction --no-progress --ansi cedx/coveralls
+          export PATH="$PATH:$HOME/.composer/vendor/bin"
+          coveralls build/logs/phpunit/clover.xml
+        continue-on-error: true
 
   behat:
     name: Behat (PHP ${{ matrix.php }})

src/Core/Bridge/Doctrine/EventListener/PublishMercureUpdatesListener.php

@@ -73,7 +73,7 @@ final class PublishMercureUpdatesListener
      * @param array<string, string[]|string> $formats
      * @param HubRegistry|callable           $hubRegistry
      */
-    public function __construct(ResourceClassResolverInterface $resourceClassResolver, IriConverterInterface $iriConverter, $resourceMetadataFactory, SerializerInterface $serializer, array $formats, MessageBusInterface $messageBus = null, $hubRegistry = null, ?GraphQlSubscriptionManagerInterface $graphQlSubscriptionManager = null, ?GraphQlMercureSubscriptionIriGeneratorInterface $graphQlMercureSubscriptionIriGenerator = null, ExpressionLanguage $expressionLanguage = null)
+    public function __construct(ResourceClassResolverInterface $resourceClassResolver, IriConverterInterface $iriConverter, ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory, SerializerInterface $serializer, array $formats, MessageBusInterface $messageBus = null, $hubRegistry = null, ?GraphQlSubscriptionManagerInterface $graphQlSubscriptionManager = null, ?GraphQlMercureSubscriptionIriGeneratorInterface $graphQlMercureSubscriptionIriGenerator = null, ExpressionLanguage $expressionLanguage = null)
     {
         if (null === $messageBus && null === $hubRegistry) {
             throw new InvalidArgumentException('A message bus or a hub registry must be provided.');
@@ -173,14 +173,10 @@ private function storeObjectToPublish($object, string $property): void
             return;
         }
 
-        if ($this->resourceMetadataFactory instanceof ResourceMetadataCollectionFactoryInterface) {
-            try {
-                $options = $this->resourceMetadataFactory->create($resourceClass)->getOperation()->getMercure();
-            } catch (OperationNotFoundException $e) {
-                return;
-            }
-        } else {
-            $options = $this->resourceMetadataFactory->create($resourceClass)->getAttribute('mercure', false);
+        try {
+            $options = $this->resourceMetadataFactory->create($resourceClass)->getOperation()->getMercure() ?? false;
+        } catch (OperationNotFoundException $e) {
+            return;
         }
 
         if (\is_string($options)) {
@@ -273,12 +269,7 @@ private function publishUpdate($object, array $options, string $type): void
             $data = json_encode(['@id' => $object->id]);
         } else {
             $resourceClass = $this->getObjectClass($object);
-            if ($this->resourceMetadataFactory instanceof ResourceMetadataCollectionFactoryInterface) {
-                $context = $options['normalization_context'] ?? $this->resourceMetadataFactory->create($resourceClass)->getOperation()->getNormalizationContext();
-            } else {
-                // TODO: remove in 3.0
-                $context = $options['normalization_context'] ?? $this->resourceMetadataFactory->create($resourceClass)->getAttribute('normalization_context', []);
-            }
+            $context = $options['normalization_context'] ?? $this->resourceMetadataFactory->create($resourceClass)->getOperation()->getNormalizationContext();
 
             $iri = $options['topics'] ?? $this->iriConverter->getIriFromItem($object, null, UrlGeneratorInterface::ABS_URL);
             $data = $options['data'] ?? $this->serializer->serialize($object, key($this->formats), $context);

src/Core/Bridge/Symfony/Bundle/Resources/config/doctrine_orm_mercure_publisher.xml

@@ -11,7 +11,7 @@
         <service id="api_platform.doctrine.orm.listener.mercure.publish" class="ApiPlatform\Core\Bridge\Doctrine\EventListener\PublishMercureUpdatesListener">
             <argument type="service" id="api_platform.resource_class_resolver" />
             <argument type="service" id="api_platform.iri_converter" />
-            <argument type="service" id="api_platform.metadata.resource.metadata_factory" />
+            <argument type="service" id="api_platform.metadata.resource.metadata_collection_factory" />
             <argument type="service" id="api_platform.serializer" />
             <argument>%api_platform.formats%</argument>
             <argument type="service" id="messenger.default_bus" on-invalid="ignore" />