-
-
Notifications
You must be signed in to change notification settings - Fork 305
refactor: necessary refactoring of pyproject.toml #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Adds requires-python tag/attributes which helps users+build_tool/pip to find minimum version supported * Changes version constraint from exact to lowest version supported to be used
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✨ No files to analyze in this PR. Need help? Join our Discord for support! |
@sansyrox |
CodSpeed Performance ReportMerging #1232 will degrade performances by 25.45%Comparing 🎉 Hooray!
|
Benchmark | BASE |
HEAD |
Change | |
---|---|---|---|---|
❌ | test_exception_handling[/sync/get/no_dec-get] |
4.7 ms | 5.6 ms | -16.18% |
❌ | test_basic_get[/sync/dict-sync dict get-sync-dict] |
4.7 ms | 6.3 ms | -25.45% |
Did these change, because i saw in many big projects that they dont put upper bound limit for deps instead they just define lower bound limit supported, later i am able to understand the reason little bit. |
@thePromger , update them here :D |
# conditional | ||
"uvloop~=0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'", | ||
"watchdog == 4.0.1", | ||
"uvloop >= 0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's pin uvloop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can i know the reason behing it?
bcoz if we dont pin so pip will automatically do install correct version according to host pc requirements
"inquirerpy >= 0.3.4", | ||
"multiprocess >= 0.70.14", | ||
"orjson >= 3.11.0", | ||
"rustimport >= 1.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's pin the latest working versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bro
i dont think that we should pin them, i saw fastapi, django, pandas, polars all are have specified requirement constraint as <= not like ==.
if we pin (==) then we need to update it regularly and if we just specify minimum version supported/required then if some breaking changes come to the dependency being in used, then only we need to fix that by finding work around or just limit to previous versions before the version which has breaking changes
@sansyrox
what i am able to understand that this 25% performance drop is due to because we unpin the exact version, which allows pip to use latest version supported by host requirements let me test some senarious in robyn's CI inside this PR itself |
@sansyrox |
Adds requires-python tag/attributes which helps users+build_tool/pip to find minimum version supported
Changes version constraint from exact to lowest version supported to be used
Adding uv.lock file to be used in CI/CD or for development by some other maintainers
PR Checklist
Please ensure that:
Pre-Commit Instructions: