Skip to content

refactor: necessary refactoring of pyproject.toml #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: necessary refactoring of pyproject.toml #1232

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6733c28
refactor: some add, refactor, changes in pyproject.toml file
thePromger Aug 7, 2025
4fddc3a
test
thePromger Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ build-backend = "maturin"
[project]
name = "robyn"
version = "0.72.0"
requires-python = ">=3.9"
description = "A Super Fast Async Python Web Framework with a Rust runtime."
authors = [{ name = "Sanskar Jethi", email = "sansyrox@gmail.com" }]
license = { file = "LICENSE" }
Expand All @@ -24,17 +25,17 @@ classifiers = [
"Programming Language :: Python :: Implementation :: CPython",
]
dependencies = [
"inquirerpy == 0.3.4",
"multiprocess == 0.70.14",
"orjson == 3.11.0",
"rustimport == 1.3.4",
"inquirerpy >= 0.3.4",
"multiprocess >= 0.70.14",
"orjson >= 3.11.0",
"rustimport >= 1.3.4",
Comment on lines +28 to +31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pin the latest working versions

Copy link
Contributor Author

@thePromger thePromger Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro
i dont think that we should pin them, i saw fastapi, django, pandas, polars all are have specified requirement constraint as <= not like ==.
if we pin (==) then we need to update it regularly and if we just specify minimum version supported/required then if some breaking changes come to the dependency being in used, then only we need to fix that by finding work around or just limit to previous versions before the version which has breaking changes

# conditional
"uvloop~=0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'",
"watchdog == 4.0.1",
"uvloop >= 0.21.0; sys_platform != 'win32' and platform_python_implementation == 'CPython' and platform_machine != 'armv7l'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's pin uvloop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can i know the reason behing it?
bcoz if we dont pin so pip will automatically do install correct version according to host pc requirements

"watchdog >= 4.0.1",
]

[project.optional-dependencies]
"templating" = ["jinja2 == 3.0.1"]
"templating" = ["jinja2 >= 3.0.1"]

[project.urls]
Documentation = "https://robyn.tech/"
Expand All @@ -48,19 +49,19 @@ test_server = "integration_tests.base_routes:main"

[dependency-groups]
dev = [
"black==23.1",
"commitizen==2.40",
"isort==5.11.5",
"maturin==0.14.12",
"pre-commit==2.21.0",
"ruff==0.1.3",
"black >= 23.1",
"commitizen >= 2.40",
"isort >= 5.11.5",
"maturin >= 0.14.12",
"pre-commit >= 2.21.0",
"ruff >= 0.1.3",
]
test = [
"nox==2023.4.22",
"pytest==7.2.1",
"pytest-codspeed==1.2.2",
"requests==2.28.2",
"websocket-client==1.5.0",
"nox >= 2023.4.22",
"pytest >= 7.2.1",
"pytest-codspeed >= 3.0.0",
"requests >= 2.28.2",
"websocket-client >= 1.5.0",
]


Expand Down
Loading