fix(core/ui): check if should inline markdown or not (#4040)

Author: marcoscaceres

src/core/ui.js

@@ -11,6 +11,7 @@
 import { html, pluralize } from "./import-maps.js";
 import css from "../styles/ui.css.js";
 import { markdownToHtml } from "./markdown.js";
+import { reindent } from "./reindent.js";
 import { sub } from "./pubsubhub.js";
 export const name = "core/ui";
 
@@ -266,10 +267,15 @@ function rsErrorToHTML(err) {
   const plugin = err.plugin
     ? `<p class="respec-plugin">(plugin: "${err.plugin}")</p>`
     : "";
+
   const hint = err.hint
-    ? `\n<p class="respec-hint"><strong>How to fix:</strong> ${markdownToHtml(
-        err.hint,
-        { inline: true }
+    ? `\n${markdownToHtml(
+        `<p class="respec-hint"><strong>How to fix:</strong> ${reindent(
+          err.hint
+        )}`,
+        {
+          inline: !err.hint.includes("\n"),
+        }
       )}\n`
     : "";
   const elements = Array.isArray(err.elements)

src/core/xref.js

@@ -456,9 +456,7 @@ function showErrors({ ambiguous, notFound }) {
   };
 
   const howToFix = (howToCiteURL, originalTerm) => {
-    return docLink`
-    [See search matches for "${originalTerm}"](${howToCiteURL}) or
-    ${"[Learn about this error|#error-term-not-found]"}.`;
+    return docLink`[See search matches for "${originalTerm}"](${howToCiteURL}) or ${"[Learn about this error|#error-term-not-found]"}.`;
   };
 
   for (const { query, elems } of notFound.values()) {