Skip to content

Commit 654ea3b

Browse files
Merge branch 'main' into validate_latest
2 parents 43c5c90 + a1dabeb commit 654ea3b

File tree

10 files changed

+166
-146
lines changed

10 files changed

+166
-146
lines changed

builds/respec-aom.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builds/respec-dini.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builds/respec-geonovum.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builds/respec-w3c.js

Lines changed: 139 additions & 137 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

builds/respec-w3c.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "respec",
3-
"version": "31.0.1",
3+
"version": "31.0.2",
44
"license": "W3C",
55
"description": "A technical specification pre-processor.",
66
"engines": {

src/w3c/templates/cgbg-headers.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// @ts-check
2+
import { l10n, renderFeedback } from "./headers.js";
23
import { html } from "../../core/import-maps.js";
3-
import { l10n } from "./headers.js";
44
import showLogo from "../../core/templates/show-logo.js";
55
import showPeople from "../../core/templates/show-people.js";
66

@@ -104,6 +104,10 @@ export default (conf, options) => {
104104
${showPeople(conf, "authors")}
105105
`
106106
: ""}
107+
${conf.github || conf.wgPublicList
108+
? html`<dt>${l10n.feedback}</dt>
109+
${renderFeedback(conf)}`
110+
: ""}
107111
</dl>
108112
${conf.alternateFormats
109113
? html`<p>

src/w3c/templates/headers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export default (conf, options) => {
333333
</div>`;
334334
};
335335

336-
function renderFeedback(conf) {
336+
export function renderFeedback(conf) {
337337
const definitions = [];
338338
// Github feedback...
339339
if (conf.github) {

tests/spec/w3c/headers-spec.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2382,6 +2382,20 @@ describe("W3C — Headers", () => {
23822382
});
23832383

23842384
describe("Feedback", () => {
2385+
for (const specStatus of cgStatus) {
2386+
it(`includes feedback links for CG's ${specStatus} status`, async () => {
2387+
const ops = makeStandardOps({
2388+
specStatus,
2389+
github: "w3c/respec",
2390+
group: "wicg",
2391+
});
2392+
const doc = await makeRSDoc(ops);
2393+
const [dt] = contains(doc, ".head dt", "Feedback:");
2394+
const dd = dt.nextElementSibling;
2395+
expect(dd.querySelector("a[href^='https://github.com/']")).toBeTruthy();
2396+
});
2397+
}
2398+
23852399
it("includes a Feedback: with a <dd> to github issues", async () => {
23862400
const doc = await makeRSDoc(
23872401
makeStandardOps({ github: "w3c/respec", specStatus: "WD" })

0 commit comments

Comments
 (0)