-
-
Notifications
You must be signed in to change notification settings - Fork 401
w3c/conformance end event is not being published in ARIA spec #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The quick fix is to add explicit #2122 caused this where the module won't publish an cc: @marcoscaceres |
Thanks - that has fixed the issue. If it is too hard to fix in respec then issuing a respec error if the section is missing would be fine. At least it would be easy to find and resolve the issue. |
We should see about fixing some of the aria scrpit to move off the old ReSpec events model. We have a lot of legacy code in ReSpec just to support the aria specs, and it’s a bit of a burden as we deprecated those events about 3 years ago. |
@marcoscaceres if there is someone who can help us I'd be happy to try to make this happen. The folks who wrote the code are not involved any more and I don't think any of us fully understand everything that is going on so some help would be appreciated. |
@marcoscaceres Do you have a "migration guide" for how to "move off of the old ReSpec events model"? The only "event-ish" thing I see documented in the current ReSpec wiki is: https://github.com/w3c/respec/wiki/respecIsReady Note that the ARIA specs currently use the following ReSpec events:
|
@carmacleod The events are not documented as they're implementation details. We'll slowly deprecate them in favor of well defined APIs (https://github.com/w3c/respec/issues/1976).
"start", "save" and "end" events don't exist anymore. For "start-all", use The order is:
Me and Marcos are not fully available this month, but I'll be able to help more at the end of the month. |
Important info
(not sure what this means)
Description of problem
What happened (e.g., it crashed)?:
ARIA specific scripts are not running.
For example https://github.com/w3c/aria/blob/master/common/script/aria.js - the events end and end-all do not seem to be called.
But what I was expecting?:
The end and end-all events to fire and the script to run
The text was updated successfully, but these errors were encountered: