Skip to content

bug: client is nil#413

Open
izouxv wants to merge 2 commits into
spf13:masterfrom
izouxv:master
Open

bug: client is nil#413
izouxv wants to merge 2 commits into
spf13:masterfrom
izouxv:master

Conversation

@izouxv
Copy link
Copy Markdown

@izouxv izouxv commented Jan 1, 2024

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@izouxv izouxv force-pushed the master branch 2 times, most recently from 4834153 to 5e4e749 Compare June 29, 2024 14:00
@spf13
Copy link
Copy Markdown
Owner

spf13 commented May 7, 2026

Two issues before this can move forward:

  1. CLA not signed. Please sign the CLA at https://cla-assistant.io/spf13/afero — this is required for all contributions.

  2. Two unrelated fixes bundled together. The sftpfs nil-client fix (not setting File.client in Create/Open) is a clear correctness bug and should be its own PR. The SymlinkIfPossible behavior change (absolute → relative symlinks) is a separate design decision with different implications and needs its own discussion.

Please split into two PRs after signing the CLA. The sftpfs nil fix is high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants