Use appropriate User-Agent in HTTP header#30
Open
tovrstra wants to merge 3 commits intosphinx-extensions2:mainfrom
Open
Use appropriate User-Agent in HTTP header#30tovrstra wants to merge 3 commits intosphinx-extensions2:mainfrom
tovrstra wants to merge 3 commits intosphinx-extensions2:mainfrom
Conversation
Author
|
Stuck at the RTD build, see readthedocs/readthedocs.org#12468 @chrisjsewell Do you see a potential solution? I'm a bit stuck. |
|
I tested and it works @tovrstra 🎉 |
Author
|
Two bug fixes for the price of one, thanks to @stsewd for helping out. @chrisjsewell This should be ready for review. Thanks for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
I'd try avoiding a configurable user-agent and instead implement an appropriate one, which is less hassle for end users. This fixes the issues with Wikipedia tooltips for me. @goekce @Skunnyk Can you try whether this works for you too? Thanks!