Skip to content

feat(trigger-http): add SPIN_HTTP_IDLE_INSTANCE_TIMEOUT_SECS env var#3463

Closed
TheRayquaza wants to merge 1 commit intospinframework:mainfrom
TheRayquaza:mateo.lelong/http-idle-timeout-env-var
Closed

feat(trigger-http): add SPIN_HTTP_IDLE_INSTANCE_TIMEOUT_SECS env var#3463
TheRayquaza wants to merge 1 commit intospinframework:mainfrom
TheRayquaza:mateo.lelong/http-idle-timeout-env-var

Conversation

@TheRayquaza
Copy link
Copy Markdown

cc spinframework/containerd-shim-spin#426 for the intended usage

Signed-off-by: Mateo Lelong <mateo.lelong@datadoghq.com>
@itowlson
Copy link
Copy Markdown
Collaborator

@TheRayquaza @kate-goldenring Looking at the discussion on spinframework/containerd-shim-spin#426, I'm not clear if this is still needed, or if the shim will handle it by setting the CliArgs struct fields from code. (It feels a bit weird for the CLI to have to environment-variable-ify anything that SpinKube wants to set, but if that's where we are then so be it.)

If it is still needed, do we think there should be corresponding environment variables for other instance reuse parameters?

@TheRayquaza
Copy link
Copy Markdown
Author

in fact not needed anymore 👌 closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants