Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Conversation

edgarulg
Copy link
Contributor

Support resourceManagerTags in GCE. See: https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates/insert

Adds resourceManagerTags in the description operation and add it in the instanceTemplateProperties.

Issue related: spinnaker/spinnaker#6931

this PR replaced the previous PR in clouddriver because I want to leave only my changes related to resource-manager-tags

@edgarulg
Copy link
Contributor Author

I was not able to add tests as part of my changes because there is not an easy way to mock the BasicGoogleDeployHandler. I think we need to add testing to this cloud provider so I created the following issue to refactor the code: spinnaker/spinnaker#6985
As I'm going to work in more new features of GCE in the next days I can work on the refactor as well but I will work on the refactor after this small change.

@edgarulg edgarulg merged commit 88d1fd0 into master Sep 27, 2024
22 checks passed
@edgarulg edgarulg deleted the add-resource-manager-tags branch September 27, 2024 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants