Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Conversation

edgarulg
Copy link
Contributor

@edgarulg edgarulg commented Oct 10, 2024

Key point about the refactor.

  1. I translated the whole class BasicGoogleDeployHandler into java.
  2. I split up the handle method into small single responsibility methods.
  3. I defined unit testing for most of the new methods I created to prove functionality.
  4. I do not include any new feature or change that was not defined by the BasicGoogleDeployHandler before.

Related to: spinnaker/spinnaker#6985

@edgarulg
Copy link
Contributor Author

I published and deployed a snapshot version with my refactor and I validated a GCE deploy worked as expected. I didn't tests all possible configurations as part of my e2e validation.

@edgarulg
Copy link
Contributor Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Oct 23, 2024

refresh

✅ Pull request refreshed

@edgarulg
Copy link
Contributor Author

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Oct 23, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Nov 20, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 20, 2024
@mergify mergify bot merged commit bbcd4c7 into spinnaker:master Nov 20, 2024
24 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.37
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants