This repository was archived by the owner on Oct 2, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable #6290
Merged
mergify
merged 15 commits into
spinnaker:master
from
edgarulg:refactor-basic-gce-handler
Nov 20, 2024
Merged
refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable #6290
mergify
merged 15 commits into
spinnaker:master
from
edgarulg:refactor-basic-gce-handler
Nov 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change it to java
I published and deployed a snapshot version with my refactor and I validated a GCE deploy worked as expected. I didn't tests all possible configurations as part of my e2e validation. |
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio rebase |
☑️ Nothing to do
|
dbyron-sf
reviewed
Oct 23, 2024
...driver-google/src/main/groovy/com/netflix/spinnaker/clouddriver/google/deploy/GCEUtil.groovy
Show resolved
Hide resolved
.../java/com/netflix/spinnaker/clouddriver/google/deploy/handlers/BasicGoogleDeployHandler.java
Outdated
Show resolved
Hide resolved
mattgogerly
approved these changes
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
auto merged
Merged automatically by a bot
ready to merge
Approved and ready for a merge
target-release/1.37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key point about the refactor.
Related to: spinnaker/spinnaker#6985