Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable #6290

Merged
merged 15 commits into from
Nov 20, 2024
Merged

refactor(gce): Refactor BasicGoogleDeployHandler to be more readable and testable #6290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c41505a
refactor(gce): return Scheduling object instead ServiceAccount
edgarulg Oct 10, 2024
3dae71a
refactor(gce): split BasicGoogleDeployHandler into small methods and …
edgarulg Oct 10, 2024
0711baf
refactor(gce): write test for BasicGoogleDeployHandler.java
edgarulg Oct 10, 2024
ed87704
refactor(gce): deprecate BasicGoogleDeployHandler.groovy
edgarulg Oct 10, 2024
8b3b535
refactor(gce): check if acceleratorConfig is not null
edgarulg Oct 10, 2024
88fef84
refactor(gce): check if acceleratorConfig is not null
edgarulg Oct 10, 2024
d7ffb94
refactor(gce): check if getUseSourceCapacity is not null
edgarulg Oct 10, 2024
a6be707
Merge branch 'master' into refactor-basic-gce-handler
edgarulg Oct 22, 2024
c623134
chore(gce): fix merge conflicts with master
edgarulg Oct 22, 2024
46e7379
Merge branch 'edgarulg-refactor-basic-gce-handler'
edgarulg Oct 22, 2024
cd35e56
Resolved merge conflicts
edgarulg Oct 23, 2024
1902c7c
fix(gce): remove multiple calls to get region and location
edgarulg Oct 28, 2024
425f22d
fix(gce): wrap whole method in try catch statement
edgarulg Oct 28, 2024
0df9514
fix(gce): log all zones when configure zones explicit
edgarulg Oct 29, 2024
7d9b3e0
Merge branch 'master' into refactor-basic-gce-handler
mergify[bot] Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clouddriver-google/clouddriver-google.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ dependencies {
testImplementation "org.assertj:assertj-core"
testImplementation "org.junit.jupiter:junit-jupiter-api"
testImplementation "org.mockito:mockito-core"
testImplementation "org.mockito:mockito-inline"
testImplementation "org.mockito:mockito-junit-jupiter"
testImplementation "org.objenesis:objenesis"
testImplementation "org.spockframework:spock-core"
Expand Down
2 changes: 1 addition & 1 deletion ...ver-google/src/main/groovy/com/netflix/spinnaker/clouddriver/google/deploy/GCEUtil.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ class GCEUtil {
: []
}

static ServiceAccount buildScheduling(BaseGoogleInstanceDescription description) {
static Scheduling buildScheduling(BaseGoogleInstanceDescription description) {
def scheduling = new Scheduling()

if (description.preemptible != null) {
Expand Down
Loading
Loading