Skip to content

Conversation

rahul-chekuri
Copy link

@rahul-chekuri rahul-chekuri commented Apr 21, 2025

  • Renamed EmbeddedPrometheusBootstrapConfiguration as TestPrometheusConfiguration and now TestPrometheusConfiguration dynamically allocate and register Prometheus container ports without using hardcoded ports.

  • Removed dependency on predefined server.port and management.server.port values for integration tests.

  • Management server port is dynamically obtained during runtime and exposed for Prometheus to scrape metrics.

  • Prometheus container’s mapped port is dynamically registered into the environment (embedded.prometheus.port) at runtime.

  • Fixed ManagementTest to use the dynamically registered Prometheus port (embedded.prometheus.port).

  • Added logic in BaseIntegrationTest to update dynamicEndpoint to PrometheusRemoteService

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 2916175: Replace hardcoded ports with random ports logic.

  • 9457ba8: Replace hardcoded ports with random ports logic.

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.


server:
port: 8080
#server:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants