Skip to content

Commit 12da3f7

Browse files
reduce cognotive complexity(code climate)
1 parent 985829d commit 12da3f7

File tree

1 file changed

+34
-28
lines changed

1 file changed

+34
-28
lines changed

src/android/FileTransferBackground.java

Lines changed: 34 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -410,38 +410,44 @@ private void acknowledgeEvent(String eventId, CallbackContext context) {
410410
* Handle ACK data and send it to the JS.
411411
*/
412412
private void handleAck(final Data ackData) {
413-
// If upload was successful
414-
if (!ackData.getBoolean(UploadTask.KEY_OUTPUT_IS_ERROR, false)) {
415-
// Read response from file if present
416-
String response = null;
417-
if (ackData.getString(UploadTask.KEY_OUTPUT_RESPONSE_FILE) != null) {
418-
response = readFileToStringNoThrow(ackData.getString(UploadTask.KEY_OUTPUT_RESPONSE_FILE));
419-
}
413+
if (!ackData.getBoolean(UploadTask.KEY_OUTPUT_IS_ERROR, false)) {
414+
handleSuccessfulUpload(ackData);
415+
} else {
416+
handleFailedUpload(ackData);
417+
}
418+
}
420419

421-
long startUploadTime = ackData.getLong("output_upload_start_time", 0);
422-
long finishUploadTime = ackData.getLong("output_upload_finish_time", 0);
423-
long uploadDuration = finishUploadTime - startUploadTime;
424-
425-
HashMap<String, Object> uploadData = new HashMap<>();
426-
uploadData.put("outputId", ackData.getString(UploadTask.KEY_OUTPUT_ID));
427-
uploadData.put("response", response);
428-
uploadData.put("statusCode", ackData.getInt(UploadTask.KEY_OUTPUT_STATUS_CODE, -1));
429-
if (uploadDuration > 0) {
430-
uploadData.put("uploadDuration", uploadDuration);
431-
uploadData.put("finishUploadTime", finishUploadTime);
432-
}
420+
private void handleSuccessfulUpload(Data ackData) {
421+
String response = null;
422+
if (ackData.getString(UploadTask.KEY_OUTPUT_RESPONSE_FILE) != null) {
423+
response = readFileToStringNoThrow(ackData.getString(UploadTask.KEY_OUTPUT_RESPONSE_FILE));
424+
}
433425

434-
sendSuccess(uploadData);
435-
} else {
436-
// The upload was a failure
437-
sendError(
438-
ackData.getString(UploadTask.KEY_OUTPUT_ID),
439-
ackData.getString(UploadTask.KEY_OUTPUT_FAILURE_REASON),
440-
ackData.getBoolean(UploadTask.KEY_OUTPUT_FAILURE_CANCELED, false)
441-
);
442-
}
426+
long startUploadTime = ackData.getLong("output_upload_start_time", 0);
427+
long finishUploadTime = ackData.getLong("output_upload_finish_time", 0);
428+
long uploadDuration = finishUploadTime - startUploadTime;
429+
430+
HashMap<String, Object> uploadData = new HashMap<>();
431+
uploadData.put("outputId", ackData.getString(UploadTask.KEY_OUTPUT_ID));
432+
uploadData.put("response", response);
433+
uploadData.put("statusCode", ackData.getInt(UploadTask.KEY_OUTPUT_STATUS_CODE, -1));
434+
435+
if (uploadDuration > 0) {
436+
uploadData.put("uploadDuration", uploadDuration);
437+
uploadData.put("finishUploadTime", finishUploadTime);
443438
}
444439

440+
sendSuccess(uploadData);
441+
}
442+
443+
private void handleFailedUpload(Data ackData) {
444+
sendError(
445+
ackData.getString(UploadTask.KEY_OUTPUT_ID),
446+
ackData.getString(UploadTask.KEY_OUTPUT_FAILURE_REASON),
447+
ackData.getBoolean(UploadTask.KEY_OUTPUT_FAILURE_CANCELED, false)
448+
);
449+
}
450+
445451
/**
446452
* Cleanup response file and ACK entry.
447453
*/

0 commit comments

Comments
 (0)