Add time-based slides #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes possible to fill these fields from the slider admin.
dportalesr
reviewed
Sep 7, 2017
app/models/spree/slide.rb
Outdated
| end | ||
|
|
||
| def in_time? | ||
| Time.now.between?(starts_at || 1.second.ago, ends_at || 1.second.from_now) |
There was a problem hiding this comment.
Favor the use of Time.current instead of Time.now
The fallback slide should only be retrieved when there is no slides to be shown.
kevinnio
force-pushed
the
master
branch
3 times, most recently
from
291f144 to
c3e15af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes possible to control slides publication using timestamps. This adds three new behaviors:
starts_atandends_atare defined are only shown if they are published andTime.currentis betweenstarts_atandends_at.starts_atdefined will be be shown only if they are published andstarts_atis in the past.starts_atandends_atareniland are always shown if they are published.Users can use the new
in_timescope to get only the slides that are supposed to be visible at a given time.Also, this adds fields to capture
starts_atandends_atfor each slide in the admin UI.