-
Notifications
You must be signed in to change notification settings - Fork 30
refactor: final adjustments for vector management and add spotless plugin #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: final adjustments for vector management and add spotless plugin #46
Conversation
@VLSMB @zxuexingzhijie 辛苦审核下本次调整。涉及的比较多文件 |
Related to [Task] 代码大重构 #37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the vector management system to remove hardcoded dependencies and improve extensibility, while also adding the Spotless code formatting plugin.
- Abstracts vector store management to support multiple vector database implementations
- Removes hardcoded
AgentVectorStoreManager.java
and introduces new service interfaces - Adds Spotless plugin for automatic code formatting
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
AbstractVectorStoreService.java |
Major refactor - Introduces agent-based vector store operations with metadata filtering |
AgentVectorStoreService.java |
New interface defining agent-specific vector store operations |
SimpleVectorStoreService.java |
Simplified to extend abstract base class and focus on SimpleVectorStore implementation |
AnalyticVectorStoreService.java |
Refactored to support AnalyticDbVectorStore implementation |
VectorStoreServiceFactory.java |
Updated to create AgentVectorStoreService implementations |
AgentVectorService.java |
Refactored to use new AgentVectorStoreService interface |
AgentSearchRequest.java |
New request model with agent-specific search parameters |
DocumentConverterUtil.java |
Added agent-aware document conversion methods |
SchemaProcessorUtil.java |
Added database configuration creation utility |
Various other files | Cleanup of unused code and interface adjustments |
pom.xml |
Added Spotless plugin configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...-ai-alibaba-data-agent-chat/src/main/java/com/alibaba/cloud/ai/util/SchemaProcessorUtil.java
Outdated
Show resolved
Hide resolved
...-ai-alibaba-data-agent-chat/src/main/java/com/alibaba/cloud/ai/util/SchemaProcessorUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/alibaba/cloud/ai/service/vectorstore/AbstractAgentVectorStoreService.java
Show resolved
Hide resolved
...ata-agent-management/src/main/java/com/alibaba/cloud/ai/service/impl/AgentVectorService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/alibaba/cloud/ai/service/vectorstore/AbstractAgentVectorStoreService.java
Show resolved
Hide resolved
.../src/main/java/com/alibaba/cloud/ai/service/vectorstore/AbstractAgentVectorStoreService.java
Show resolved
Hide resolved
9bc3fa5
to
ff46e4a
Compare
...t-chat/src/main/java/com/alibaba/cloud/ai/service/vectorstore/VectorStoreServiceFactory.java
Outdated
Show resolved
Hide resolved
...t-chat/src/main/java/com/alibaba/cloud/ai/service/vectorstore/VectorStoreServiceFactory.java
Outdated
Show resolved
Hide resolved
...-ai-alibaba-data-agent-chat/src/main/java/com/alibaba/cloud/ai/util/SchemaProcessorUtil.java
Show resolved
Hide resolved
- rename classes and remove unused code - adjust AgentVectorStoreServiceFactory and SchemaServiceFactory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews