This repository was archived by the owner on May 14, 2025. It is now read-only.
Local Deployer - Docker - Network property is being ignored #451
Labels
status/need-triage
Team needs to triage and take a first look
When using the local deployer to deploy a containerized application the network property for Docker (
deployer.*.local.docker.network
) is being ignored.The cause for this seems to be, that in the DockerCommandBuilder constructor the dockerNetwork is set:
https://github.com/spring-cloud/spring-cloud-deployer/blob/062e8cb60a7e88430992405c2f7c358fb792c919/spring-cloud-deployer-local/src/main/java/org/springframework/cloud/deployer/spi/local/DockerCommandBuilder.java#L64-L66
and then reused when building the execution command:
https://github.com/spring-cloud/spring-cloud-deployer/blob/062e8cb60a7e88430992405c2f7c358fb792c919/spring-cloud-deployer-local/src/main/java/org/springframework/cloud/deployer/spi/local/DockerCommandBuilder.java#L104-L107
instead of using
localDeployerProperties.getDocker().getNetwork()
analogous to the other properties like volume mountings.This problem was also already reported in the old local deployer repository: spring-attic/spring-cloud-deployer-local#199 (comment)
The text was updated successfully, but these errors were encountered: