Migrate Kafka Binder (& Streams) to Core Retry #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
The Spring Retry project goes to its sunset; therefore, a goal for the whole portfolio is to get rid of its dependency while putting the project into a maintenance mode. Use Spring Core `RetryTemplate` API instead * Fix `@StreamRetryTemplate` docs to talk about Core `RetryTemplate`. And fix respective tests to use a new import * Migrate `AbstractBinder` to Core Retry * Migrate `DefaultPollableMessageSource` to Core Retry and supporting retry API from Spring Integration * Migrate `KafkaMessageChannelBinder`, including respective tests * Fix typos in Javadocs * Fix for some Spring Boot 4.0 breaking changes to make project to be built at least at some level * Migrate Kafka Streams module to Core Retry * Fix parent POM to not use `-local` repositories to avoid authentication * Remove redundant `repositories` section from the Kafka binder as it is inherited from the parent * Comment out `spring-cloud-stream-integration-tests` module since it fail with not related problems * The Rabbit Binder would be fixed separately when Spring Boot is ready While this is a breaking change internally, this does not affect the end-user API too much. Moreover, the rest of Spring projects are already doing such a breaking change migration. So, aim for `spring-retry` removal in the end anyway The `spring-cloud-stream-schema-registry-server` fails for some Spring Boot incompatibility or my out-dated local SNAPSHOTs
sobychacko
approved these changes
Sep 9, 2025
|
@olegz I synced with @artembilan on this PR, and it looks good to me. I will let you merge the PR; however, before merging it, we need to re-enable the tests and investigate why the tests in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spring Retry project goes to its sunset;
therefore, a goal for the whole portfolio is
to get rid of its dependency while putting the project into a maintenance mode. Use Spring Core
RetryTemplateAPI instead@StreamRetryTemplatedocs to talk about CoreRetryTemplate. And fix respective tests to use a new importAbstractBinderto Core RetryDefaultPollableMessageSourceto Core Retry and supporting retry API from Spring IntegrationKafkaMessageChannelBinder, including respective tests-localrepositories to avoid authenticationrepositoriessection from the Kafka binder as it is inherited from the parentspring-cloud-stream-integration-testsmodule since it fail with not related problemsWhile this is a breaking change internally, this does not affect the end-user API too much. Moreover, the rest of Spring projects are already doing such a breaking change migration. So, aim for
spring-retryremoval in the end anywayThe
spring-cloud-stream-schema-registry-serverfails for some Spring Boot incompatibility or my out-dated local SNAPSHOTs