feat: Add equals, hashCode, deep copy, and tests to MiniMaxChatOptions #2358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances MiniMaxChatOptions by: - Updating `equals` and `hashCode` methods for proper object comparison. - Updating `copy()` method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state. - Adding `MiniMaxChatOptionsTests` to verify `copy()`, builders, setters, and default values. Signed-off-by: Alexandros Pappas <apappascs@gmail.com>
apappascs
changed the title
markpollack
requested review from
ilayaperumalg
and removed request for
tzolov and
ilayaperumalg
|
rebased and added a few more tests and defensive copies of some getters. merged into main d9e3037 and backported to 1.0.x thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances MiniMaxChatOptions by:
equalsandhashCodemethods for proper object comparison.copy()method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state.MiniMaxChatOptionsTeststo verifycopy(), builders, setters, and default values.