Fixed an issue where tool calls could not function properly when using the new version of Ollama. #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i.ollama.OllamaChatModel` could not work correctly when a tool call occurred while using Ollama. Signed-off-by: Sun Yuhan <1085481446@qq.com>
|
Hi @tzolov , would you please have time to review this PR? Thank you. |
|
@sunyuhan1998 Thanks for fixing the bug! Rebased and merged as 72fe3bf. Also, back-ported the changes into 1.0.x via 1eecd17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the issue: #3369, when using the new version of Ollama and a tool call is made, a
NullPointerExceptionoccurs involving"evalDuration".This is because, according to the official Ollama API documentation: https://github.com/ollama/ollama/blob/main/docs/api.md#generate-a-chat-completion, fields like
eval_durationare only populated when the model response is completed. However, during a tool call, thefrommethod oforg.springframework.ai.ollama.OllamaChatModelfails to handle null values properly, leading to this issue.I'm not entirely sure whether it's due to any changes Ollama may have made to the response interface. However, by adding more robust null checks, we can make this functionality work correctly.