Skip to content

Step names must be unique #3757 #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 152 commits into from
Closed

Step names must be unique #3757 #4544

wants to merge 152 commits into from

Conversation

FBibonne
Copy link

@FBibonne FBibonne commented Feb 5, 2024 •
edited
Loading

@FBibonne
Copy link
Author

FBibonne commented Feb 5, 2024

Solves #3757

@FBibonne
Copy link
Author

FBibonne commented Feb 5, 2024

WIP because 5 tests still fail

@FBibonne
Copy link
Author

FBibonne commented Feb 6, 2024

All tests passed.

  • pom is updated to have a have a version of slf4j-api corresponding to simple-slf4j
  • unicity of names is checked when starting the job , just before calling listeners because step names may be known only in JobScope
  • in FlowJob.findStepsThrowingIfNameNotUnique, I suggest to remove the else block when state is instance of StepHolder : it is never executed

@FBibonne FBibonne marked this pull request as ready for review February 6, 2024 07:27
@FBibonne FBibonne mentioned this pull request Feb 6, 2024
Open
@FBibonne FBibonne force-pushed the 3757-unique-step-names branch from da3e37c to f27a0b7 Compare February 2, 2025 07:46
Fabrice Bibonne and others added 22 commits February 2, 2025 08:54
@FBibonne
test(check unicity of job name in a flow) failing test
9bdfcf5 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne
test(check unicity of job name in a flow) step name as a job parameter
094814d 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne
fix(log for tests) print log in console for tests
aed184b 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne
feat(step name unicity) spring-projects#3757
2615485 
the names of different steps in a job must be different

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne
fix(step name unicity WITHIN A FLOW)
54209ee 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne
fix(java format)
7dcd990 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Fix bean configuration in DefaultBatchConfiguration
f9172e2 
Before this commit, the dependency injection style used to
define some infrastructure beans was incompatible with the
bean method proxying being disabled.

This commit fixes the issue by injecting dependencies through
the parameters of bean definition methods.

Resolves spring-projects#4543

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Add JobRegistrySmartInitializingSingleton
831b975 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Refine contribution spring-projects#4521
31fad2f 
- Update reference documentation
- Minor test updates

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Update antora-extensions to v1.8.2
6788c96 
Issue spring-projects#4534

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Exclude slf4j-api transitive dependency from sqlite-jdbc
1962c7c 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@NotBjoggisAtAll @FBibonne
Fix javadoc referencing Long when it should be Double
f1ad112 
Resolves spring-projects#4526

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Check dirty flag of step execution context before update in inner loop
ca5959b 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@acktsap @FBibonne
Remove static imports in production code
0fe0826 
Signed-off-by: Taeik Lim <sibera21@gmail.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Fix exception when parsing empty values in DefaultJobParametersConverter
058d66c 
Resolves spring-projects#4505

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Let SimpleJobRepository#deleteJobInstance delete corresponding step e…
9f29b90 
…xecutions

Resolves spring-projects#4382

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Fix deprecations in MongoPagingItemReader
d8ee739 
Resolves spring-projects#4552

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@ilpyoyang @FBibonne
Add AbstractTaskletStepBuilder copy constructor
2fba532 
This commit includes tests for the copy constructor
of AbstractTaskletStepBuilder and for the faultTolerant
method, specifically after taskExecutor has been set.

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Refine contribution spring-projects#4471
bfa1516 
- Update tests
- Move test class to the core module

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@petrovskimario @FBibonne
Update deprecated code that uses StepExecutionListenerSupport
2bed698 
Closes spring-projects#4538

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@acktsap @FBibonne
Make util classes to follow style guide
65b85fc 
Signed-off-by: Taeik Lim <sibera21@gmail.com>

Issue spring-projects#4545

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@chldppwls12 @FBibonne
Fix incorrect code example in documentation
9fa21d2 
Issue spring-projects#4550

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
xeounxzxu and others added 21 commits February 2, 2025 08:54
@xeounxzxu @FBibonne
Add test coverage of isNonDefaultExitStatus in ExitStatusTests
3d2022d 
Issue spring-projects#4690

Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Update implementations of PagingQueryProvider
38ec3ad 
Replaces the implementation of `DerbyPagingQueryProvider`
with that corresponding to DB2 and adds an integration test
that failed with the previous implementation.

Deprecates `SqlWindowingPagingQueryProvider` for removal,
which was effectively only used by `DerbyPagingQueryProvider`.

Resolves spring-projects#4733

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Add integration tests for PagingQueryProvider
0c70478 
Adds testcontainers based tests for DB2, MySQL, MariaDB, Postgres, Sql Server and Oracle Database, as well as standard tests for HSQL and SQLite.

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@hpoettker @FBibonne
Add state reset on close of AbstractPaginatedDataItemReader
f279578 
Resolves spring-projects#1086

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Add note about not scoping step beans with job scope
5cbc166 
Resolves spring-projects#3900

Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Clarify wildcard usage to select input files with Java configuration
7c10fab 
Resolves spring-projects#4707

Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@Solodye @FBibonne
Add unit tests for ExecutionContext#get methods
10b1571 
Related to spring-projects#718

Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@Seungpang @FBibonne
Fix closing tag for listeners in documentation
c6e1b65 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@Seungpang @FBibonne
Fix incorrect link
b899332 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Prepare release 5.2.1
2f2ddb2 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Update nexus sync action in maven central release process
6c860dd 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Update maven-central-release.yml
48e891e 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Add pgp signing in maven-central-release.yml
a405919 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Release version 5.2.1
7f83214 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Next development version
f16ac00 
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Update latest news in README.md
6eb2da7 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Add sample job based on PetClinic application
89c7100 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Fix tests
396eac3 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Add dco.yml
3aaa0df 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Update CONTRIBUTING.md to include details about the DCO
0a530e0 
Signed-off-by: Mahmoud Ben Hassine <mbenhassine@vmware.com>
Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@fmbenhassine @FBibonne
Add test cases to cover key generation for empty identifying job para…
1c28dac 
…meters set

Related to spring-projects#4755

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@gmail.com>
@FBibonne FBibonne force-pushed the 3757-unique-step-names branch from f27a0b7 to 1c28dac Compare February 2, 2025 07:55
@FBibonne FBibonne closed this Feb 2, 2025
@FBibonne
Copy link
Author

FBibonne commented Feb 2, 2025

Status changed to draft because of troubles with git signoff

@FBibonne FBibonne reopened this Feb 2, 2025
@FBibonne FBibonne marked this pull request as draft February 2, 2025 10:10
@FBibonne FBibonne closed this Feb 3, 2025
@FBibonne FBibonne deleted the 3757-unique-step-names branch February 3, 2025 04:10
@FBibonne
Copy link
Author

FBibonne commented Feb 3, 2025

Closed because of trouble with git : new PR is #4756

@FBibonne FBibonne mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: core pr-for: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.