Skip to content

Upgrade jedis minor and lettuce major versions. #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
viktoriya-kutsarova wants to merge 1 commit into from
Closed

Upgrade jedis minor and lettuce major versions. #3295

viktoriya-kutsarova wants to merge 1 commit into from
+97 −59

Conversation

@viktoriya-kutsarova
Copy link
Contributor

@viktoriya-kutsarova viktoriya-kutsarova commented Jan 14, 2026 •
edited
Loading

This PR upgrades the underlying Redis client drivers to the following versions:

Lettuce: 6.8.1.RELEASE → 7.2.1.RELEASE
Jedis: 7.0.0 → 7.2.1

API Compatibility Fixes

The Lettuce 7.x upgrade required the following compatibility adjustments:

  • Updated keys() method calls to use String pattern parameter instead of byte[]
  • Updated credential resolution to use getCredentialsProvider().resolveCredentials().block() instead of direct property access on RedisURI

Closes #3282

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 14, 2026
@viktoriya-kutsarova viktoriya-kutsarova mentioned this pull request Jan 14, 2026
Merged
4 tasks
mp911de
mp911de reviewed Jan 14, 2026
View reviewed changes
...ava/org/springframework/data/redis/connection/lettuce/LettuceReactiveClusterKeyCommands.java
Assert.notNull(pattern, "Pattern must not be null");

return cmd.keys(pattern).collectList();
return cmd.keys(new String(ByteUtils.getBytes(pattern))).collectList();
Copy link
Member

@mp911de mp911de Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let's use LettuceConverters.toString(…) to follow a single conversion approach.

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveKeyCommands.java
Assert.notNull(pattern, "Pattern must not be null");
// TODO: stream elements instead of collection
return cmd.keys(pattern).collectList().map(value -> new MultiValueResponse<>(pattern, value));
return cmd.keys(new String(ByteUtils.getBytes(pattern))).collectList().map(value ->
Copy link
Member

@mp911de mp911de Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Let's use LettuceConverters.toString(…) to follow a single conversion approach.

@mp911de
Copy link
Member

mp911de commented Jan 14, 2026

Would it make sense to switch directly to Jedis' newly introduced RedisClient types or would this change be too large for handling it within this PR?

@mp911de mp911de added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 14, 2026
@mp911de mp911de self-assigned this Jan 14, 2026
@viktoriya-kutsarova
Upgrade jedis minor and patch versions and lettuce major version.
288aed8 
Closes spring-projects#3282

Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
@viktoriya-kutsarova viktoriya-kutsarova force-pushed the topic/upgrade-lettuce-and-jedis branch from f7fd4be to 288aed8 Compare January 19, 2026 11:33
onobc pushed a commit that referenced this pull request Jan 19, 2026
@viktoriya-kutsarova @onobc
Upgrade to Lettuce 7.2.1.RELEASE and Jedis 7.2.1.
c4508bf 
Closes #3282
Original Pull Request #3295

Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
onobc added a commit that referenced this pull request Jan 19, 2026
@onobc
Polishing.
169cb9b 
- Fix import order on few classes
- Extract credentials verification into helper methods
- Use AssertJ extracting which handles null check as well

See #3282
Original Pull Request #3295

Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc onobc added this to the 4.1 M1 (2026.0.0) milestone Jan 19, 2026
@onobc
Copy link
Contributor

onobc commented Jan 19, 2026

👋🏻 @viktoriya-kutsarova

Thank you for another excellent contribution!

Closing via c4508bf

I also made a small polishing commit 169cb9b

@onobc onobc closed this Jan 19, 2026
mp911de added a commit that referenced this pull request Jan 20, 2026
@mp911de
Polishing.
15bc786 
Refactor new String(…) from byte array and ByteBuffer handling to remove duplicates.

See #3282
Original Pull Request #3295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels

type: dependency-upgrade A dependency upgrade

Projects

None yet

Milestone

4.1 M1 (2026.0.0)

Development

Successfully merging this pull request may close these issues.

Upgrade to Jedis 7.2.0

4 participants

@viktoriya-kutsarova @mp911de @onobc @spring-projects-issues