Add batch update support to JdbcClient#36944
Open
Empatixx wants to merge 1 commit into
Open
Conversation
Introduce batchUpdate(List<Object[]>) and batchUpdate(SqlParameterSource...) terminal operations on JdbcClient.StatementSpec, delegating to JdbcOperations and NamedParameterJdbcOperations respectively. Batch updates previously required dropping down to JdbcTemplate or NamedParameterJdbcTemplate. Closes spring-projectsgh-33843 Signed-off-by: Jiří Krokviak <j.krokviak@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
I'm expecting more fluent batch API like: client.sql("insert into person(name, age) values (:name, :age)").batch().param("name", name1).param("age", age1).add().param("name", name2).param("age", age2).batchUpdate(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds batch update support to
JdbcClient, requested in #33843.It adds two terminal methods to
JdbcClient.StatementSpec:int[] batchUpdate(List<Object[]> batchArgs)— positional?parametersint[] batchUpdate(SqlParameterSource... batchArgs)— named:xparametersThey simply delegate to
JdbcOperations.batchUpdateandNamedParameterJdbcOperations.batchUpdate, so batch updates no longer need to drop down toJdbcTemplateorNamedParameterJdbcTemplate.Also adds integration tests (indexed + named) and updates the reference docs.
This issue is assigned to @sdeleuze — happy to adjust the API shape if you prefer a different design.