Upgrade Go, use generics instead of interface, use slice.Equal and int range (#137)

Author: spring1843

.github/linters/.golangci.yml

@@ -17,15 +17,14 @@ issues:
   exclude-rules:
     - path: /
       linters:
-        - nosnakecase
         - nlreturn
-        - forcetypeassert
+        - gci
+        - gomnd
         - ifshort
-        - scopelint
+        - forcetypeassert
         - varnamelen
         - lll
         - testpackage
-        - gomnd
         - wsl
         - gochecknoglobals
         - paralleltest
@@ -34,9 +33,6 @@ issues:
         - dupword
 linters:
   enable-all: true
-  enable:
-    - revive
-    - misspell
 
 linters-settings:
   forbidigo:

.github/workflows/tests.yaml

@@ -10,12 +10,12 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: reviewdog/action-misspell@v1
         with:
           github_token: ${{ secrets.github_token }}
           locale: "US"
-      - uses: github/super-linter@v4
+      - uses: github/super-linter@v5
         env:
           DEFAULT_BRANCH: main
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -30,15 +30,8 @@ jobs:
   tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-go@v4
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~/.cache/go-build
-            ~/go/pkg/
-            ~/go/bin/
-          key: go-cache-${{ hashFiles('go.mod') }}
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
       - run: go test -v -coverprofile=profile.cov ./...
       - uses: shogo82148/actions-goveralls@v1
         with:

array/add_two_numbers.go

@@ -25,10 +25,7 @@ func AddTwoNumbers(num1, num2 []int) []int {
 
 func equalizeLengths(num1, num2 []int) ([]int, []int) {
 	diff := int(math.Abs(float64(len(num2) - len(num1))))
-	zeros := []int{}
-	for i := 0; i < diff; i++ {
-		zeros = append(zeros, 0)
-	}
+	zeros := make([]int, diff)
 	if len(num2) > len(num1) {
 		num1 = append(zeros, num1...)
 	} else if len(num1) > len(num2) {

array/add_two_numbers_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -26,7 +26,7 @@ func TestAddTwoNumbers(t *testing.T) {
 		{[]int{9, 9, 9}, []int{9, 9, 9}, []int{1, 9, 9, 8}},
 	}
 	for i, test := range tests {
-		if got := AddTwoNumbers(test.num1, test.num2); !reflect.DeepEqual(got, test.sum) {
+		if got := AddTwoNumbers(test.num1, test.num2); !slices.Equal(got, test.sum) {
 			t.Fatalf("Failed test case #%d. Want %v got %v", i, test.sum, got)
 		}
 	}

array/bubble_sort_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -27,7 +27,7 @@ func TestBubbleSort(t *testing.T) {
 	}
 	for i, test := range tests {
 		BubbleSort(test.input)
-		if !reflect.DeepEqual(test.input, test.sorted) {
+		if !slices.Equal(test.input, test.sorted) {
 			t.Fatalf("Failed test case #%d. Want %v got %v", i, test.sorted, test.input)
 		}
 	}

array/equal_sum_subarrays.go

@@ -20,7 +20,7 @@ func EqualSubArrays(list []int) [][]int {
 
 func findSplitPoint(list []int) int {
 	lSum := 0
-	for i := 0; i < len(list); i++ {
+	for i := range len(list) {
 		lSum += list[i]
 
 		rSum := 0

array/insertion_sort_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -28,7 +28,7 @@ func TestInsertionSort(t *testing.T) {
 	}
 	for i, test := range tests {
 		InsertionSort(test.input)
-		if !reflect.DeepEqual(test.input, test.sorted) {
+		if !slices.Equal(test.input, test.sorted) {
 			t.Fatalf("Failed test case #%d. Want %v got %v", i, test.sorted, test.input)
 		}
 	}

array/product_of_all_other_elements_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -26,7 +26,7 @@ func TestProductOfAllOtherElements(t *testing.T) {
 	}
 
 	for i, test := range tests {
-		if got := ProductOfAllOtherElements(test.list); !reflect.DeepEqual(got, test.products) {
+		if got := ProductOfAllOtherElements(test.list); !slices.Equal(got, test.products) {
 			t.Fatalf("Failed test case #%d. Want %#v got %#v", i, test.products, got)
 		}
 	}

array/reverse_inplace_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -31,7 +31,7 @@ func TestReverseInPlace(t *testing.T) {
 
 	for i, test := range tests {
 		ReverseInPlace(test.list, test.start, test.end)
-		if !reflect.DeepEqual(test.list, test.reversed) {
+		if !slices.Equal(test.list, test.reversed) {
 			t.Fatalf("Failed test case #%d. Want %#v got %#v", i, test.reversed, test.list)
 		}
 	}

array/rotate_k_steps_test.go

@@ -1,7 +1,7 @@
 package array
 
 import (
-	"reflect"
+	"slices"
 	"testing"
 )
 
@@ -27,7 +27,7 @@ func TestRotateKSteps(t *testing.T) {
 
 	for i, test := range tests {
 		RotateKSteps(test.list, test.steps)
-		if !reflect.DeepEqual(test.list, test.rotatedList) {
+		if !slices.Equal(test.list, test.rotatedList) {
 			t.Fatalf("Failed test case #%d. Want %#v got %#v", i, test.rotatedList, test.list)
 		}
 	}