SQLite: Fix parsing of INSERT DEFAULT VALUES syntax #4010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue #3998 where SQLite's parser couldn't handle the valid SQL syntax "INSERT INTO table DEFAULT VALUES". The fix involves: 1. Updating the ANTLR grammar to properly support DEFAULT VALUES as part of the INSERT statement structure 2. Adding handling in convert.go for the DEFAULT VALUES case 3. Regenerating the parser from the updated grammar Fixes #3998 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #3998 where SQLite's parser couldn't handle the valid SQL syntax
INSERT INTO table DEFAULT VALUES.Problem
The SQLite parser was incorrectly structured, with
DEFAULT VALUESas an alternative to the entire INSERT statement rather than as a valid option within the INSERT INTO clause. This caused the parser to fail with:Solution
DEFAULT VALUESto be a proper option within the INSERT statement structure inSQLiteParser.g4convert.goto detect and handle the DEFAULT VALUES case, creating an appropriate AST structureTest Plan
insert_default_valuesthat verifies the syntax works correctlyINSERT INTO workspace DEFAULT VALUESnow generates valid Go codeFixes #3998
🤖 Generated with Claude Code