-
Notifications
You must be signed in to change notification settings - Fork 133
refactor(android): remove v1 embedding APIs and update to FlutterActi… #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor(android): remove v1 embedding APIs and update to FlutterActi… #263
Conversation
|
Building still complains about |
I think the fix is simply removing unused private constructors for those three java files. Can you please update those files? |
@@ -106,7 +97,7 @@ public void onMethodCall(MethodCall call, final Result result) { | |||
@Override | |||
public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) { | |||
channel = new MethodChannel(flutterPluginBinding.getBinaryMessenger(), "square_in_app_payments"); | |||
|
|||
channel.setMethodCallHandler(new SquareInAppPaymentsFlutterPlugin()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be "this"?
you should resolve this issue very quickly lots of our Square client are having issue with new release. @CLAassistant @plinio-square |
Any updates on when this will be merged? |
…vity
Summary
Migrate plugin to Android V2 embedding and remove deprecated registerWith() usage
Related issues
Related Issues
Fix #
Changelog
This commit upgrades the Android side of the plugin to use the Flutter V2 plugin API. The deprecated registerWith() method has been removed and replaced with the recommended onAttachedToEngine() lifecycle method. ActivityAware was also implemented to manage activity context when needed. This aligns with Flutter's current standards and avoids runtime warnings in apps using this plugin.
Test Plan