Make templates compatible with minijinja (Rust) #8112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves compatibility with minijinja, a template engine we're currently exploring. Additionally, it replaces several instances of Python function invocations with idiomatic use of template filters. All instances where variables have been mutated inside templates have been replaced. Most changes have been made in partials, and only a few in blocks, and all of them are fully backwards compatible, so no changes to your overrides are necessary.
Note that this PR does not replace the jinja template engine with minijinja. However, our templates are now 99% compatible with minijinja, which means we can explore alternative jinja-compatible implementations. Additionally, immutability and removal of almost all Python function invocations means much more idiomatic templating☺️
🙋♀️ Want to help testing? Just check out this branch, and build your documentation with it – it only takes a minute:
There should be no difference in output whatsoever. If there is, please let us know!