Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Commit 81d0176

Browse files
committed
Return error on failed conversion
Signed-off-by: Theo Despoudis <thdespou@hotmail.com>
1 parent 71a8bf4 commit 81d0176

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

sql/expression/function/sqrt_power.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (s *Sqrt) Eval(ctx *sql.Context, row sql.Row) (interface{}, error) {
5555

5656
child, err = sql.Float64.Convert(child)
5757
if err != nil {
58-
return nil, nil
58+
return nil, err
5959
}
6060

6161
return math.Sqrt(child.(float64)), nil

sql/expression/function/sqrt_power_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func TestSqrt(t *testing.T) {
2020
err bool
2121
}{
2222
{"null input", sql.NewRow(nil), nil, false},
23-
{"invalid string", sql.NewRow("foo"), nil, false},
23+
{"invalid string", sql.NewRow("foo"), nil, true},
2424
{"valid string", sql.NewRow("9"), float64(3), false},
2525
{"number is zero", sql.NewRow(0), float64(0), false},
2626
{"positive number", sql.NewRow(8), float64(2.8284271247461903), false},

0 commit comments

Comments
 (0)