Skip to content

Dialog button style individually configurable #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Thodor12
Copy link
Contributor

@Thodor12 Thodor12 commented Apr 6, 2023

Currently it's not possible to separately style the close and done buttons.
In my application I'm consistently holding to a "error" style for cancel buttons and a "primary" style for completion/save buttons.
This is not doable if there's only 1 property available for setting the style for both buttons.

Suggested changes:

  • Introduce separate properties for the done and close buttons
  • Rename matching text properties to refer to "dialog" instead of "modal", to match other properties
  • Thanks to prettier some formatting related things have been changed (blame prettier)

! This is a breaking change

@Thodor12 Thodor12 mentioned this pull request Apr 6, 2023
Thodor12 added a commit to Thodor12/react-native-paper-select that referenced this pull request Apr 7, 2023
@Thodor12
Copy link
Contributor Author

Thodor12 commented Apr 7, 2023

Superseded by #33

@Thodor12 Thodor12 closed this Apr 7, 2023
@Thodor12 Thodor12 deleted the Thodor12-patch-1 branch April 7, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant