Skip to content

Discord updates #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2025
Merged

Discord updates #658

merged 8 commits into from
Jan 20, 2025

Conversation

@PeterJCLaw
Copy link
Member

Suggest review by commit.

@PeterJCLaw
Fix a couple of 'team leaders' which slipped through
26568f3
@PeterJCLaw
Reflow for clearer diffs
def6b77
@PeterJCLaw
Clarify the account usage details
e58cad1
@PeterJCLaw
Clarify joining instructions for competitors
7a67c2b 
This page biases towards supervisors reading it, which is fine,
however may make it harder to interpret for competitors. This change
calls out upfront what a competitor should do to get access in
order to avoid confusion.
@PeterJCLaw
Clarify that supervisors can have access too!
7f3a814
ShadowLord2005
ShadowLord2005 reviewed Jan 20, 2025
View reviewed changes
ShadowLord2005
ShadowLord2005 reviewed Jan 20, 2025
View reviewed changes
@ShadowLord2005
Copy link
Contributor

The last sentence on Line 50 doesn't quite read right, think there needs to be an are in there

ShadowLord2005
ShadowLord2005 reviewed Jan 20, 2025
View reviewed changes
@PeterJCLaw
Copy link
Member Author

PeterJCLaw commented Jan 20, 2025 •
edited
Loading

The last sentence on Line 50 doesn't quite read right, think there needs to be an are in there

Nice! e55c474

Meta: not sure if you're aware, but it's possible to comment on files in the diff as well as lines. Doing that means we get an inline conversation thread which can be resolved in the usual way, albeit at the top of the file rather than on a line of the file. It's handy for things like this which are outside the diff.

image

@ShadowLord2005
Copy link
Contributor

Meta: not sure if you're aware, but it's possible to comment on files in the diff as well as lines. Doing that means we get an inline conversation thread which can be resolved in the usual way, albeit at the top of the file rather than on a line of the file. It's handy for things like this which are outside the diff.

Wasn't aware of that no, Still learning my way around GitHub. At some point I should probably clone some of the SR repos if only to be better able to review PRs

ShadowLord2005
ShadowLord2005 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ShadowLord2005 ShadowLord2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now.

@PeterJCLaw PeterJCLaw merged commit 3dc077a into main Jan 20, 2025
6 checks passed
@PeterJCLaw PeterJCLaw deleted the discord-updates branch January 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShadowLord2005 ShadowLord2005 ShadowLord2005 approved these changes

@samjmartin04 samjmartin04 Awaiting requested review from samjmartin04

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeterJCLaw @ShadowLord2005