Skip to content

Conversation

xiangchenjhu
Copy link
Collaborator

@xiangchenjhu xiangchenjhu commented Sep 27, 2024

Changes on those info in README:

  1. add --no_xtb option
  2. add filter_in / filter_out result
    3)update pipeline installation

amitschang
amitschang previously approved these changes Oct 3, 2024
Copy link
Member

@amitschang amitschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment

README.md Outdated

## Note:
The default output (--o) dataframe is stored in Parquet format due to its efficient storage, faster data access, and enhanced support for complex data structures. The Parquet file can be accessed in several ways:
* The default output (--o) dataframe is stored in Parquet format due to its efficient storage, faster data access, and enhanced support for complex data structures.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think --o should be either (or both) -o, --output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! updated it.

@xiangchenjhu
Copy link
Collaborator Author

Thanks for review!

@xiangchenjhu xiangchenjhu marked this pull request as ready for review October 3, 2024 22:21
@xiangchenjhu xiangchenjhu requested a review from a team as a code owner October 3, 2024 22:21
@xiangchenjhu xiangchenjhu merged commit 66a5877 into main Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants